Bug 45934 - Importing license ldif fails (60_umc/80_udm_license)
Importing license ldif fails (60_umc/80_udm_license)
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - LDAP directory
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3
Assigned To: Jannik Ahlers
Johannes Keiser
: interim-2
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-12-21 12:34 CET by Florian Best
Modified: 2018-03-14 14:38 CET (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2017-12-21 12:34:42 CET
Importing a license ldif file via the UMC module fails. (Test case 60_umc/80_udm_license).

The backend shows this error log message:

19.12.17 19:33:53.702  MODULE      ( ERROR   ) : License import failed (malformed LDIF): ValueError('Line 2: First line of record does not start with "dn:": \'objectClass\'',)
Comment 1 Florian Best univentionstaff 2017-12-21 13:41:26 CET
The "dn:" of our test ldif file was not at the start of the LDIF.
The old ldif.LDIFParser accepted this malformed LDIF file. The new one doesn't anymore. I adjusted the LDIF file in our test.

ucs-test (8.0.2-1)
605b90ce97bf | Bug #45934: fix test case 60_umc/80_udm_license

interim version, no changelog required.
Comment 2 Johannes Keiser univentionstaff 2018-01-31 12:59:27 CET
The test fails on master s3:

Following errors occurred:
-adding computer with free for personal use license:
  Die Operation ist f\xfcr dieses Objekt nicht erlaubt. Objekte des Objekttyps "computers/windows" k\xf6nnen nicht erstellt werden.

-adding user:
  Der Wert darf nicht ver\xe4ndert werden. Attribut=locked alter Wert=None neuer Wert=0

The licenses were imported successfully
Comment 3 Florian Best univentionstaff 2018-01-31 13:01:57 CET
(In reply to Johannes Keiser from comment #2)
> -adding user:
>   Der Wert darf nicht ver\xe4ndert werden. Attribut=locked alter Wert=None
> neuer Wert=0
→ This is fixed in the latest univention-directory-manager-modules package. Can you upgrade and test again please? Maybe the other test is fixed then, too.
Comment 4 Jannik Ahlers univentionstaff 2018-02-15 09:41:21 CET
Fixed just as Florian said.
Comment 5 Johannes Keiser univentionstaff 2018-02-15 16:36:39 CET
OK Test is green
OK changes
-> verified
Comment 6 Stefan Gohmann univentionstaff 2018-03-14 14:38:06 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".