Bug 46539 - ox hook requires posix and samba options on user module
ox hook requires posix and samba options on user module
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UDM (Generic)
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3
Assigned To: Felix Botner
Dirk Wiesenthal
: interim-4
: 46586 (view as bug list)
Depends on:
Blocks: 46541
  Show dependency treegraph
 
Reported: 2018-03-08 10:01 CET by Felix Botner
Modified: 2019-02-25 09:29 CET (History)
4 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 6: Setup Problem: Issue for the setup process
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.514
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Botner univentionstaff 2018-03-08 10:01:30 CET
Noticed after the update of our master system.

After the update modification of user objects are no longer possible due to a ox udm hook, which requires the options samba and posix. We have removed these options in 4.3.

I would recommend set set the options variable on the udm user module to all the options which are now default (and no longer selectable).
Comment 1 Felix Botner univentionstaff 2018-03-08 11:08:13 CET
OK, this is the Bug for UCS, we should provide backward compatibility

See Bug #46540 for necessary ok integration changes
Comment 2 Felix Botner univentionstaff 2018-03-08 12:58:52 CET
Added simulate_legacy_options() users/user.py to simulate old options, adds all old options for new objects, and for existing objects the options, which match the objectclass.

called in open()

udm-users OK
Comment 3 Daniel Tröder univentionstaff 2018-03-12 09:48:36 CET
I think this produces ERROR messages in UMC logfiles. See Bug #46586.
Comment 4 Sönke Schwardt-Krummrich univentionstaff 2018-03-12 10:01:19 CET
Every program using UDM is currently printing an error message to the logfile:

e.g. in UCS@school management-console-module-schoolcsvimport.log:

12.03.18 09:00:07.380  MODULE      ( PROCESS ) : Creating CSVTeacher(name='Anton8', school='SchuleEins', dn='uid=Anton8,cn=lehrer
,cn=users,ou=SchuleEins,dc=uni,dc=dtr')
12.03.18 09:00:07.484  ADMIN       ( ERROR   ) : 'users/user' does not specify option 'samba'
12.03.18 09:00:07.484  ADMIN       ( ERROR   ) : 'users/user' does not specify option 'kerberos'
12.03.18 09:00:07.484  ADMIN       ( ERROR   ) : 'users/user' does not specify option 'person'
12.03.18 09:00:07.484  ADMIN       ( ERROR   ) : 'users/user' does not specify option 'posix'
12.03.18 09:00:07.484  ADMIN       ( ERROR   ) : 'users/user' does not specify option 'mail'
12.03.18 09:00:07.517  MODULE      ( PROCESS ) : CSVTeacher(name='Anton8', school='SchuleEins', dn='uid=Anton8,cn=lehrer,cn=users
,ou=SchuleEins,dc=uni,dc=dtr') successfully created

I suspect that this is caused by the workaround. Maybe we should lower the error message to WARNING or PROCESS or even INFO until we have a besser solution?
Comment 5 Sönke Schwardt-Krummrich univentionstaff 2018-03-12 10:01:50 CET
*** Bug 46586 has been marked as a duplicate of this bug. ***
Comment 6 Felix Botner univentionstaff 2018-03-12 10:07:52 CET
changed log level from error to info
511d5dd3e7d905f7b2c970d1bfaebf61ed3d7290
Comment 7 Dirk Wiesenthal univentionstaff 2018-03-13 13:56:30 CET
Works for the CLI. Does not work in UMC, unfortunately. UMC sets the options again after open() is called.

While fixing this again, could you please rename the method to something starting with an underscore?
Comment 8 Felix Botner univentionstaff 2018-03-13 14:12:31 CET
* renamed simulate_legacy_options to _simulate_legacy_options
* moved call from open() to _ldap_pre_ready()

univention-directory-manager-modules 13.0.21-15A~4.3.0.201803131409
719f91c31a475db4ddab63b29c587a0efb49c23b
Comment 9 Dirk Wiesenthal univentionstaff 2018-03-13 14:32:20 CET
OK, works
Comment 10 Stefan Gohmann univentionstaff 2018-03-14 14:37:56 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".