Bug 47139 - Wrong error / unhelpful message from SchoolSanitizer
Wrong error / unhelpful message from SchoolSanitizer
Status: CLOSED WONTFIX
Product: UCS@school
Classification: Unclassified
Component: UMC
UCS@school 4.3
Other Linux
: P5 normal (vote)
: ---
Assigned To: UCS@school maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-06-05 15:47 CEST by Jürn Brodersen
Modified: 2023-06-12 15:39 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?: 5: Will affect all installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.057
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jürn Brodersen univentionstaff 2018-06-05 15:47:45 CEST
The error message from the SchoolSanitizer (ucs-school-lib/python/schoolldap.py) always returns an error message that no school exists yet, even if a school does exist.
Also the return code is set to 503 (Service Unavailable) which to me implies that a service, like LDAP, is not running.

Other sanitizer return 422.

Checking the input against all possible schools might be to expensive, but at least the error message should be adjusted.
Comment 1 Florian Best univentionstaff 2018-06-06 10:35:58 CEST
The error message says:
"
The request did not specify any school. You have to create a school before continuing. Use the "Schools" UMC module to create one.
"

In which case can you trigger this error message and a school acutally exists? It's a javascript error then.
Comment 2 Jürn Brodersen univentionstaff 2018-06-06 11:02:43 CEST
(In reply to Florian Best from comment #1)
> The error message says:
> "
> The request did not specify any school. You have to create a school before
> continuing. Use the "Schools" UMC module to create one.
> "
> 
> In which case can you trigger this error message and a school acutally
> exists? It's a javascript error then.

See bug 43080 comment 12 and bug 47140 :)

I would argue the sanitizer is used to validate the input and the error message should cover the case that the call was just used wrong as well.
Comment 3 Jan-Luca Kiok univentionstaff 2023-06-12 15:32:08 CEST
This issue has been filed against UCS@school 4.3 or earlier.

UCS 4.3 is out of maintenance and UCS components have vastly changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen this issue. In this case please provide detailed information on how this issue is affecting you.