Univention Bugzilla – Bug 47841
shorten textual import summary
Last modified: 2021-09-01 13:31:41 CEST
Customers may import 50.000 users each day, resulting in > 10.000 lines of textual summary. The textual summary of an import job should not list created/modified/deleted users if they are more that 8 (2 lines) per role. The lines with numbers ("Created ImportStaff: 10" etc) and the complete error list (regardless of length) should remain.
4 Lines per role are now allowed. Tested with: /usr/share/ucs-school-import/scripts/ucs-school-testuser-import --staff 17 --students 16 --classes 1 DEMOSCHOOL OUTPUT: Read users from input data: 33 Created ImportStaff: 17 Modified ImportStaff: 0 Deleted ImportStaff: 17 Created ImportStudent: 16 ['eyrin.holtma', 'nives.spieke', 'sissy.haseke', 'reichwein.la'] ['kuni.schieda', 'germaine.fra', 'friedbert.ei', 'ghislaine.ti'] ['jokim.kruel', 'damiana.grei', 'shika.boenit', 'tim.dallmann'] ['veva.bender', 'fritjof.buss', 'ursulina.fla', 'aswina.drews'] Modified ImportStudent: 0 Deleted ImportStudent: 16 ['yves.krautte', 'ossy.niehues', 'gundela.holt', 'irmo.beck'] ['ioakim.nehri', 'hede.tormoeh', 'ernest.lueni', 'estrid.schmi'] ['winibert.lue', 'sintbald.wro', 'camillus.lin', 'romika.farnb'] ['vidette.grim', 'masetto.knor', 'ehrenreich.t', 'floria.nieho'] Errors: 0 Pushed solution on branch troehmey/47841 with commit commit 8b42b035be8e32e8024e59d531856c4a1f2fefe9 Bug #47841: shortened import summary
QA The code works/ looks as expected. The textual summary of an import job should not list created/modified/deleted users if they are more than 8 (2 lines) per role. → you have 4x4 cf. comment 1 Was this requirement changed?
I cannot tell the reason why I did the 4x4 output. It's been too long^^ However, I committed the solution to a new updated branch: [troehmey/bug47841_v2] 2f7126b4b Bug #47841: shortened import summary And as you can see now, the output is now as intended when testing the behavior with /usr/share/ucs-school-import/scripts/ucs-school-testuser-import --staff 9 --students 8 --classes 1 DEMOSCHOOL ------ User import statistics ------ Read users from input data: 17 Created ImportStaff: 9 Modified ImportStaff: 0 Deleted ImportStaff: 9 Created ImportStudent: 8 ['hjoerdis.kal', 'andrew.loth', 'luitgunde.st', 'jim.kuhn'] ['xeno.stuetze', 'joeelle.oent', 'aretha.suren', 'volma.kemner'] Modified ImportStudent: 0 Deleted ImportStudent: 8 ['carlota.boss', 'finetta.suer', 'otker.rittma', 'almar.fergla'] ['lone.ghotb', 'siobhan.stro', 'luither.schl', 'gerdis.polat'] Errors: 0 ------ End of user import statistics ------
Created attachment 10690 [details] before
Created attachment 10691 [details] after
OK: code review OK: automatic test (only one tried: 201_import-users_basic.py) OK: manual test (see screenshots "before" and "after")
Please merge into 4.4, build and add an advisory.
Fix merged to 4.4 with b6c373892 Bug #47841: added yaml 3086cb9a8 Bug #47841: added changelog entry f109577d2 Bug #47841: Merge branch 'troehmey/bug47841_v2' into 4.4 Successful build: Package: ucs-school-import Version: 17.0.53A~4.4.0.202104181154 Branch: ucs_4.4-0 Scope: ucs-school-4.4
OK: build and advisory
Errata updates for UCS@school 4.4 v9 have been released. https://docs.software-univention.de/changelog-ucsschool-4.4v9-de.html If this error occurs again, please clone this bug.