Bug 49533 - Make creation of demoschool configurable in the school-installer
Make creation of demoschool configurable in the school-installer
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Installer
UCS@school 4.4
Other Windows ME
: P5 normal (vote)
: UCS@school 5.0 v2
Assigned To: Carlos García-Mauriño
Johannes Keiser
https://git.knut.univention.de/univen...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-05-23 16:07 CEST by Daniel Tröder
Modified: 2022-07-15 08:31 CEST (History)
5 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Usability
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2019-05-23 16:07:40 CEST
Currently it is possible to disable the creation of the demoschool during the execution of the UMC school-installer.

Add a checkbox (reflecting the state of the UCR variable -> enabled by default) that the user can deactivate to prevent the creation of the demo school.
Comment 1 Ole Schwiegert univentionstaff 2022-04-25 10:39:00 CEST
This should be implemented for 5.0
Comment 2 Carlos García-Mauriño univentionstaff 2022-04-28 14:14:58 CEST
Extended summary:

Currently there is a checkbox in the app settings for enabling the creation of the demo school (with the demo users) which is enabled by default. In the first screen of the school installer there is a text that suggests the user to change that setting before the installation:

"During the installation of UCS@school a demo school including some users will be configured for testing purposes. If you do not wish that, please set the UCR variable ucsschool/join/create_demo to no prior to the installation."

The goal is to have that checkbox in the wizard directly. This requires modifying the web interface and the `schoolinstaller` script to handle the new input. Also removing the app setting might be reasonable since it will no longer be needed (changing the setting after the app instalattion has no effect).
Comment 3 Carlos García-Mauriño univentionstaff 2022-05-13 12:04:16 CEST
Related to https://forge.univention.org/bugzilla/show_bug.cgi?id=49046
Comment 5 Johannes Keiser univentionstaff 2022-05-30 17:52:54 CEST
QA
- [x] a checkbox is shown in the schoolinstaller UMC module. The initial value is `ucsschool/join/create_demo`
- [x] demo school and students are created if checkbox is checked; and vice versa
- [x] https://git.knut.univention.de/univention/ucs/-/blob/5.0-1/test/utils/schoolinstaller.py still works

Can be merged now
Comment 6 Carlos García-Mauriño univentionstaff 2022-05-31 12:16:55 CEST
MR merged (https://git.knut.univention.de/univention/ucsschool/-/merge_requests/97), package built (`ucs-school-umc-installer`: `8.0.8A~5.0.0.202205310922`) and advisory updated (https://git.knut.univention.de/univention/ucsschool/-/commit/57b6474c3c9df5c22417a7074b1591a129cfe5a0). Tested the built package and everything is working as expected.
Comment 7 Johannes Keiser univentionstaff 2022-06-01 10:37:04 CEST
OK: advisory (e0f4e1dc6 Bug #49533: advisory)
OK: package works
-> verified
Comment 8 Carlos García-Mauriño univentionstaff 2022-07-12 13:50:31 CEST
Changelogs for `ucs-school-l10n-fr` were missing. Added in https://git.knut.univention.de/univention/ucsschool/-/commit/2ea2c70c4e11bc11f70d18392f14cf828c1231f3. Package built (`ucs-school-l10n-fr`: ` 5.0.4A~5.0.0.202207121347`) and advisory updated (https://git.knut.univention.de/univention/ucsschool/-/commit/f3e967cceca963c88fbfdc2a2a79438ab3b33e6c).
Comment 9 Johannes Keiser univentionstaff 2022-07-13 14:02:17 CEST
(In reply to Carlos García-Mauriño from comment #8)
> Changelogs for `ucs-school-l10n-fr` were missing. Added in
> https://git.knut.univention.de/univention/ucsschool/-/commit/
> 2ea2c70c4e11bc11f70d18392f14cf828c1231f3. Package built
> (`ucs-school-l10n-fr`: ` 5.0.4A~5.0.0.202207121347`) and advisory updated
> (https://git.knut.univention.de/univention/ucsschool/-/commit/
> f3e967cceca963c88fbfdc2a2a79438ab3b33e6c).

OK: changelog/advisory/package built
OK: french translation is shown
-> verified
Comment 10 Tobias Wenzel univentionstaff 2022-07-15 08:31:11 CEST
UCS@school 5.0 v2 has been released.

https://docs.software-univention.de/changelog-ucsschool-5.0v2-de.html

If this error occurs again, please clone this bug.