Bug 49963 - roles UDM hook broken on systems without schoollib
roles UDM hook broken on systems without schoollib
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Ucsschool-lib
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v3-errata
Assigned To: Jürn Brodersen
Ole Schwiegert
:
Depends on: 49917
Blocks:
  Show dependency treegraph
 
Reported: 2019-08-05 14:48 CEST by Jürn Brodersen
Modified: 2019-08-05 18:42 CEST (History)
7 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.286
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2019080521000438
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jürn Brodersen univentionstaff 2019-08-05 14:48:15 CEST
+++ This bug was initially created as a clone of Bug #49917 +++

Traceback (most recent call last):
File "/usr/share/univention-directory-manager-tools/univention-cli-server", line 218, in doit
output = univention.admincli.admin.doit(arglist)
File "/usr/lib/pymodules/python2.7/univention/admincli/admin.py", line 408, in doit
out = _doit(arglist)
File "/usr/lib/pymodules/python2.7/univention/admincli/admin.py", line 619, in _doit
univention.admin.modules.init(lo, position, module)
File "/usr/lib/pymodules/python2.7/univention/admin/modules.py", line 199, in init
update_extended_attributes(lo, module, position)
File "/usr/lib/pymodules/python2.7/univention/admin/modules.py", line 386, in update_extended_attributes
propertyHook = getattr(univention.admin.hook, propertyHookString)()
File "/usr/lib/pymodules/python2.7/univention/admin/hooks.d/ucsschool_role_computers.py", line 76, in __init__
self.is_master_or_backup = ucr['server/role'] in ('domaincontroller_master', 'domaincontroller_backup')
NameError: global name 'ucr' is not defined
Comment 1 Jürn Brodersen univentionstaff 2019-08-05 14:59:47 CEST
[4.4 86043b21b] Bug #49963: fix UcsschoolRoleComputers UDM hook on systems without schoollib
[4.4 dad251a6c] Bug #49963: yaml


Package: ucs-school-import
Version: 17.0.9A~4.4.0.201908051456
Branch: ucs_4.4-0
Scope: ucs-school-4.4
Comment 2 Jürn Brodersen univentionstaff 2019-08-05 15:29:04 CEST
[4.4 c3dbf32fc] Bug #49963: fix UcsschoolRoleComputers UDM hook on systems without schoollib 2
[4.4 a13780cee] Bug #49963: yaml2


Package: ucs-school-import
Version: 17.0.10A~4.4.0.201908051526
Branch: ucs_4.4-0
Comment 3 Ole Schwiegert univentionstaff 2019-08-05 16:30:05 CEST
Changelog&Advisory: OK
Package installs:OK
Hook replicated: OK
Hook runs on master: OK
Hook skipped on member: OK

Tested with master+member 4.3->4.4
Tested with master+member 4.4->4.4
Comment 4 Daniel Tröder univentionstaff 2019-08-05 18:42:32 CEST
UCS@school 4.4 v3 has been released.

https://docs.software-univention.de/release-notes-ucsschool-4.4v3-de.html

If this error occurs again, please clone this bug.