Bug 51000 - Revert of "pass ldap connection to udm hooks" failed
Revert of "pass ldap connection to udm hooks" failed
Status: RESOLVED WORKSFORME
Product: UCS
Classification: Unclassified
Component: UDM - Extended Attributes
UCS 4.4
Other Linux
: P5 normal (vote)
: ---
Assigned To: UMC maintainers
UMC maintainers
:
Depends on: 44203
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-23 12:50 CET by Sönke Schwardt-Krummrich
Modified: 2021-06-24 13:27 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain: 0.091
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): API change
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sönke Schwardt-Krummrich univentionstaff 2020-03-23 12:50:18 CET
I just noticed that univention/admin/modules.py still contains the code

register_ldap_connection = getattr(propertyHook, 'hook_ldap_connection', None)
if register_ldap_connection:
	register_ldap_connection(lo, position)

that should have been reverted in bug 44203. We should remove this code and mentioned in the original bug.




+++ This bug was initially created as a clone of Bug #44203 +++

When a UDM hook is called (creation for example here: univention/admin/modules.py:297) the existing UDM-LDAP connection is not passed to it. If it needs LDAP/UDM acces, it must then get those credentials itself - often involving Administator or root access.

Change univention.admin.hook.simpleHook in a way, that the current UDM-LDAP connection is usable in classes inheriting from it.

As univention.admin.hook.simpleHook currently has no __init__(), the API change can probably be done backwards compatible there. All existing hooks have to be checked first.
Comment 1 Florian Best univentionstaff 2021-06-24 13:27:35 CEST
Code does not exists anymore.