Bug 51542 - diagnostic module to check for empty recordUID and set sourceUID
diagnostic module to check for empty recordUID and set sourceUID
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - System diagnostic
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v5-errata
Assigned To: Toni Röhmeyer
Tobias Wenzel
https://forge.univention.org/bugzilla...
:
Depends on:
Blocks: 51494
  Show dependency treegraph
 
Reported: 2020-06-22 08:49 CEST by Daniel Tröder
Modified: 2020-07-30 13:14 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2020-06-22 08:49:38 CEST
In a UCS@school domain that uses the UCS@school import, all users that should be considered for imports must have a unique recordUID-sourceUID combination.
While having an empty record_uid is theoretically OK, as long as that's unique, it is a sure sign of an error by the user making the import. This will most likely lead to problems in the future, when the record_uid calculation is fixed and the user can then not be found anymore by the import.

Look for users with a source_uid but no record_uid:

"(&(ucsschoolSourceUID=*)(!(ucsschoolRecordUID=*)))"
Comment 1 Toni Röhmeyer univentionstaff 2020-06-22 15:22:37 CEST
Diagnosis module added with commit

commit 3fbce0960f13ccb9c756aa46091b4b3d9b3989ec
Bug #51542: added diagnosis module for detecting empty recordUIDs

on feature branch 
troehmey/bug51542_check_for_empty_recorduid


Feature tested by modifying a user via udm and then running the diagnosis module.
Comment 2 Tobias Wenzel univentionstaff 2020-06-23 14:19:44 CEST
QA -> All ok -> please merge&build
functionality -> works as expected
code -> looks good
build -> works

---------------------------------

[troehmey/bug51542_check_for_empty_recorduid] 3fbce0960 Bug #51542: added diagnosis module for detecting empty recordUIDs


udm users/user modify --dn "uid=demo_student,cn=schueler,cn=users,ou=DEMOSCHOOL,dc=wenzel-univention,dc=intranet" --set ucsschoolSourceUID='henri'

leads to

  File "./907_ucsschool_empty_recorduid.py", line 82, in run
    raise Warning(description + details)
univention.management.console.modules.diagnostic.Warning: In a UCS@school domain that uses the UCS@school import, all users that should be considered for imports must have a unique recordUID-sourceUID combination.
Having an empty recordUID is theoretically OK, but will most likely lead to problems in the future and the user may not be found by the import.

The following problems were found: 

  uid=demo_student,cn=schueler,cn=users,ou=DEMOSCHOOL,dc=wenzel-univention,dc=intranet
   - has ucsschoolSourceUID but no ucsschoolRecordUID set.
Comment 3 Tobias Wenzel univentionstaff 2020-06-23 14:20:26 CEST
Sorry, REOPEN for merge&build
Comment 4 Toni Röhmeyer univentionstaff 2020-06-24 10:38:28 CEST
Feature branch merged to 4.4 with commits

commit 7124ee8bb4a0c4f6f3a342272a6999818c5c8b78
Bug #51542: added yaml entry

commit f1f21e7107523938c7c7e22b8dadf7470f641968
Bug #51542: added changelog entry

commit 99d5be88a91fe4dc9fdd5462423c9bd78bef1643
Bug #51542: Merge branch 'troehmey/bug51542_check_for_empty_recorduid' into 4.4


Successful build:

Package: ucs-school-umc-diagnostic
Version: 1.0.0-11A~4.4.0.202006241019
Branch: ucs_4.4-0
Scope: ucs-school-4.4
Comment 5 Tobias Wenzel univentionstaff 2020-06-24 16:47:16 CEST
QA -> all ok -> VERIFIED

YAML -> ok
Changelog -> ok
Functionality -> works as expected
No merge conflicts
Comment 6 Tobias Wenzel univentionstaff 2020-06-25 10:27:41 CEST
UCS@school 4.5 v5 has been released (errata update to the release).

http://docs.software-univention.de/changelog-ucsschool-4.4v5-de.html

If this error occurs again, please clone this bug.
Comment 7 Tobias Wenzel univentionstaff 2020-07-30 13:14:42 CEST
Due to technical problems, the version had to be republished.

UCS@school 4.4 v5 has been released (errata update to the release).

http://docs.software-univention.de/changelog-ucsschool-4.4v5-de.html#changelog:ucsschool:2020-07-30

If this error occurs again, please clone this bug.