Univention Bugzilla – Bug 51936
Suggestions for cleanups and bugfixes in univention-samba4
Last modified: 2020-09-03 11:36:18 CEST
univention-samba4.mo should be the file itself, not a directory containing a de.mo (German is already specified by the previous /de/ in the path)
> debian/univention-samba4.install:de.mo usr/share/locale/de/LC_MESSAGES/univention-samba4.mo The 2nd argument in debian/*.install files is a DIRECTORY Actually the file is not used at all by scripts/mount_extfs_with_user_xattr.py. Also one memory leak and two buffer overruns in the C code of "pam_univentionsambadomain.c". [phahn/51936-samba4] b4b94ea07c Bug #51936 samba4: Cleanup getuser() [phahn/51936-samba4] 4d5b08fa53 Bug #51936 samba4: Fix memory leak and buffer overrun [phahn/51936-samba4] 6be2aa9937 Bug #51936 samba4: Use pam_syslog [phahn/51936-samba4] 55698b520c Bug #51936 samba4: Make functions static [phahn/51936-samba4] a781607520 Bug #51936 samba4: Remove unused #include<>s [phahn/51936-samba4] 33556e2315 Bug #51936 samba4: Simplify debian/*.install [phahn/51936-samba4] e55891b1cf Bug #51936 samba4: Fix use of dh_fixperms [phahn/51936-samba4] 2c1011393e Bug #51936 samba4: Add shlibs:Depends [phahn/51936-samba4] 588f0a59be Bug #51936 samba4: Actually use translation [phahn/51936-samba4] 753c88ed24 Bug #51936 samba4: Fix translation docker run --rm -ti -v $PWD:/work:ro -w /work registry.salsa.debian.org/reproducible-builds/diffoscope univention-samba4_8.0.0-31A~4.4.0.202004221550_amd64.deb univention-samba4_8.0.0-31_amd64.deb ... │ │ ├── ./control │ │ │ @@ -1,13 +1,13 @@ │ │ │ Package: univention-samba4 │ │ │ -Version: 8.0.0-31A~4.4.0.202004221550 │ │ │ +Version: 8.0.0-31 │ │ │ Architecture: amd64 │ │ │ Maintainer: Univention GmbH <packages@univention.de> │ │ │ -Installed-Size: 400 │ │ │ -Depends: univention-config (>= 8.0.2-1), univention-directory-manager-tools (>= 13.0.21-21), univention-join (>= 10.0.0-12), shell-univention-lib (>= 6.0.9-8), python-univention-lib (>= 1.0.45), python-univention (>= 6.0.9-3), python-netifaces, samba (>= 2:4.7.3+d fsg-1A~4.3.0.201712181832), samba-vfs-modules, libunivention-ldb-modules, ldb-tools, winbind, univention-samba-local-config, pwgen, univention-samba4-sysvol-sync (= 8.0.0-31A~4.4.0.202004221550) │ │ │ +Installed-Size: 395 │ │ │ +Depends: ldb-tools, libunivention-ldb-modules, pwgen, python-netifaces, python-univention (>= 6.0.9-3), python-univention-lib (>= 1.0.45), samba (>= 2:4.7.3+dfsg-1A~4.3.0.201712181832), samba-vfs-modules, shell-univention-lib (>= 6.0.9-8), univention-config (>= 8. 0.2-1), univention-directory-manager-tools (>= 13.0.21-21), univention-join (>= 10.0.0-12), univention-samba-local-config, univention-samba4-sysvol-sync (= 8.0.0-31), winbind, libc6 (>= 2.3), libpam0g (>= 0.99.7.1), libunivention-config0 (>= 5.0.0) ... │ │ ├── ./md5sums │ │ │ ├── ./md5sums │ │ │ │┄ Files differ │ │ │ ├── line order ... │ │ │ │ -usr/share/locale/de/LC_MESSAGES/univention-samba4.mo/de.mo │ │ │ │ +usr/share/locale/de/LC_MESSAGES/univention-samba4.mo ... ├── data.tar.xz │ ├── data.tar │ │ ├── file list ... │ │ │ --rw-r--r-- 0 root (0) root (0) 10312 2020-04-22 13:50:20.000000 ./lib/security/pam_univentionsambadomain.so │ │ │ +-rw-r--r-- 0 root (0) root (0) 6216 2020-04-22 13:50:20.000000 ./lib/security/pam_univentionsambadomain.so ... │ │ ├── ./etc/univention/registry.info/variables/univention-samba4.cfg ... │ │ ├── ./usr/share/doc/univention-samba4/changelog.Debian.gz ... │ │ ├── ./usr/share/univention-samba4/scripts/mount_extfs_with_user_xattr.py
Fixing the wrong path should "already" be handled by one of the commits from Bug #51656 for UCS-5, which replaces the direct use of "msgfmg" with the new generic mechanism "univention-l10n" to be used by all UCS packages. The remaining changes are still valid - so thanks for your new subject. TODO: testing (module is only included in /etc/pam.d/samba AFAIK)