Univention Bugzilla – Bug 53491
Include patches from Phoenix - Theme
Last modified: 2021-06-23 15:55:56 CEST
The Portal has been improved for Phoenix. We should include their progress. Notable change is the new theming.
d1281ff09153ab766090876a377c5adfd7b88ff2 [#257] fix: Finalize theme 4886728f4689dba92e1c637f3009e7c0ce24098d [#214] fix: Fix existing unit tests a3bbb32c738cfa702ac95b05fe7715e965389363 [#214] fix: Fix existing tests 4a98c5003118417b8066f8a18c5982d5aa92e34a [#228] feat: Notifications are shown in edit mode; if more than 1 notification is present, one can now remove all at once b5287500239a55ad52c10cbcb0c75936206ff582 [#246] fix: Require english title for Portal e5499b52e6f3c67c72a54ede7d3f9f26625f504e [#254] fix: Close ChooseTab modal if changing active tab to portal 1fda0aee612cd8a0c6b53a5e974ca49f8daf8f8f [#257] feat: Support UCS Themes 2412f3a4b03460ed7eb1e83a5fca523b8aa880b2 [#232] fix: anchor styling is just for cookie banner c96b46339c724ad4fdc5b3f0fa0fda638b6004b9 [#245] feat: If only one language is available, hide language menu; choose this language as the current language 7824779a2b4beaa09e2d2e3c1abbb183141f579d [#232] fix: anchor styling (specifically helps in cookie banner) 739cdeb3c46769f61e569364b52d14c963770311 [#238] fix: increase top margin for save button in edit sidebar; added translations 31a92310b7ef93cfd65f1eb4bfff96a95b883792 [#242] feat: Menus can now be edited in edit mode (via virtual categories) 689d4e8ec4503d78c1d8c361637a9e68e0998ba8 [#241] feat: add anonymous to edit mode c08ddc0ecd7b990a831759d6ebfaa941f467840c [#240] feat: add linkTarget to edit mode d7e671b09c64d5cc524a71bf4b5a8def63d706f2 [#237] feat: add defaultLinkTarget to edit mode 498813bccad91e1c31bad18dbc167339da14994d [#238] feat: add ensureLogin to edit mode b4797e34cffdaf4978c905b45758894c8525031a [#232] add focus style to primary button e477c06d24f901a6e47dbecbbb1186a77a5d45de [#232] from "end" to "flex-end" 16e4b806a0dd4716952c2557eadaad9746672616 [#214] fix: postinst check for symlink existance
[5.0-0 b7c5b2a875] Bug #53491: Include patches from Phoenix - Theme 60 files changed, 909 insertions(+), 718 deletions(-) Package: univention-portal Version: 4.0.5-55A~5.0.0.202106211811 Branch: ucs_5.0-0 Scope: errata5.0-0
Found a regression, included all commits from today: 8f9647da44415b212acd4b6e8524cf9725bc235f [#228] fix: Do not hide login button behind empty notifications element c90ea865f94faecd8fa9e8c03807a4f188444dc1 [#257] fix: Use checkerboard-pattern 8421c1f9b025a51727c7194620ed11cfce800fa7 [#228] fix: Remove notifications completely after a click on (x) d4e1046b617cc9524989819d5d0d52e9747cff03 [#257] fix: Typo in CSS [5.0-0 6627134d05] Bug #53491: Fix login button hidden behind another element 7 files changed, 25 insertions(+), 12 deletions(-) Package: univention-portal Version: 4.0.5-56A~5.0.0.202106221029 Branch: ucs_5.0-0 Scope: errata5.0-0
3ad536c53d0ab88acc3d7932343146c21c7ef704 [#257] fix: Tabs now have a tile with logo, not just the logo [5.0-0 a58b17e3f0] Bug #53491: Tabs now have a full logo tile, not just the logo 10 files changed, 46 insertions(+), 19 deletions(-) Package: univention-portal Version: 4.0.5-57A~5.0.0.202106221359 Branch: ucs_5.0-0 Scope: errata5.0-0
c182ab5efa329b07c50b7770c0b63e6f405c0d3c [#257] fix: Change background of active tab [5.0-0 5c3d54b754] Bug #53491: Changed tab background 4 files changed, 10 insertions(+), 3 deletions(-) Package: univention-portal Version: 4.0.5-58A~5.0.0.202106221649 Branch: ucs_5.0-0 Scope: errata5.0-0
9882281a4d4c7d54853d02f27928ec39e281b121 [#257] fix: Scale header icons 0a86254c2f303279e87776572ca70781ab65d9cb [#257] fix: Lost CSS variables [5.0-0 00814724ab] Bug #53491: Lost CSS variables 4 files changed, 42 insertions(+), 37 deletions(-) [5.0-0 0aceac8a3c] Bug #53491: Scale header icons 4 files changed, 9 insertions(+), 2 deletions(-) Package: univention-portal Version: 4.0.5-61A~5.0.0.202106222022 Branch: ucs_5.0-0 Scope: errata5.0-0
613cf907bc117222e58253aaafe35732cbb353fe [#257] fix: CSS improvements - buttons 54b5fc3c900b0c400dd5e78184a4eb70e1429511 [#242] fix: Increased dropzone for categories; removed virtual categories from category order when saving 74bc46b6e5a73927374b52193845c40e45f04d39 [#257] fix: CSS improvements b2e649a094089550c31712c4afee5306ec99e889 [#245] feat: Disable the currently active language from the language submenu [5.0-0 65afc6b6f8] Bug #53491: Last CSS improvements 17 files changed, 67 insertions(+), 42 deletions(-) Package: univention-portal Version: 4.0.5-62A~5.0.0.202106231040 Branch: ucs_5.0-0 Scope: errata5.0-0
OK: light theme is implemented OK: no regression OK: other changes look good OK: yaml -> verified Some things that can be fixed in later errata Design inconsitencies with umc [ ] design of toggle buttons (header buttons) (for toggled state) [ ] checkbox styling [ ] disabled inputfields styling Portal [ ] the missing hover style does not feel good [ ] is the css duplicated? the dev console shows every ruleset twice or is this a devconsole "bug" [ ] when i open the portal there is a loading animation but the ensureLogin redirect is after the loading anim, when the portal has already fully rendered. could this be adjusted? [ ] Some labels for portals/{portal,folder,category,entry} differ in portal and in portal udm module. Can be/is confusing [ ] drag and drop an portal entry trigger multiple success notifications, should only be one imo [ ] flyout-wrapper uses 100vh but and also displaces it from the top which means part of the bottom is cut of; you cant scroll all the way to the bottom in e.g. notifications [ ] a tooltip for the "Portal Menu" "User Menu" categories would be good Bugs?
<https://errata.software-univention.de/#/?erratum=5.0x21>