Bug 54349 - [UDM REST Client] lower dependency requirement to prevent incompatible update
[UDM REST Client] lower dependency requirement to prevent incompatible update
Status: CLOSED FIXED
Product: Components
Classification: Unclassified
Component: udm-rest-api-client
unspecified
Other Linux
: P5 normal (vote)
: ---
Assigned To: Daniel Tröder
Ole Schwiegert
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2022-01-18 09:39 CET by Daniel Tröder
Modified: 2022-01-18 12:46 CET (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.057
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2022011721000207
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2022-01-18 09:39:41 CET
the requirement of click>=8 in the Python UDM REST API client leads in the ucsschool-apis app version 0.1.0 to a conflict with the installation of typer==0.3.0, as it requires click<8.

typer>=0.4.0 would fix the problem, but the more desirable solution is to lower the required version of click in the Python UDM REST API client, as it does not use features from click 8.

Lower the click version required by the Python UDM REST API client to something below 8.
Comment 1 Daniel Tröder univentionstaff 2022-01-18 09:52:44 CET
[master bc0a965] version 1.0.7: lower required version of click (Bug #54349)

A git tag "1.0.7" was added.

* Coverage (100%): https://app.codecov.io/gh/univention/python-udm-rest-api-client
* Docs (Published): https://udm-rest-client.readthedocs.io/en/latest/
* Travis CI (success): https://app.travis-ci.com/github/univention/python-udm-rest-api-client
* GH Actions - Linting (success): https://github.com/univention/python-udm-rest-api-client/actions?query=workflow%3A%22Code+Linting%22
* GH Actions - Integration tests (success, but wrong badge): https://github.com/univention/python-udm-rest-api-client/actions?query=workflow%3A%22Integration+tests%22

The package was released on https://test.pypi.org/project/udm-rest-client/1.0.7/

When approved by QA, I'll release it via production PyPI.
Comment 3 Ole Schwiegert univentionstaff 2022-01-18 11:20:22 CET
Everything looks in order. package is installable.

I tested also in the ucsschool-apis app:

Install app
Install udm-rest-client from TestPyPI
Click still on v7
Comment 4 Daniel Tröder univentionstaff 2022-01-18 12:46:27 CET
Release on PyPI: https://pypi.org/project/udm-rest-client/1.0.7/