Univention Bugzilla – Full Text Bug Listing |
Summary: | UVMM JavaScript JSHint issue cleanup | ||
---|---|---|---|
Product: | UCS | Reporter: | Philipp Hahn <hahn> |
Component: | UMC - Virtual machines (UVMM) | Assignee: | Philipp Hahn <hahn> |
Status: | CLOSED FIXED | QA Contact: | Felix Botner <botner> |
Severity: | minor | ||
Priority: | P5 | CC: | gohmann, walkenhorst |
Version: | UCS 3.1 | Flags: | hahn:
Patch_Available+
|
Target Milestone: | UCS 3.1-1-errata | ||
Hardware: | All | ||
OS: | Linux | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | Cleanup | |
Max CVSS v3 score: | |||
Attachments: | Cleanup JSHint issues |
The patch was applied: svn In addition to that the Python-UVMM-UMC code was cleaned up as well: svn40827...40843 121a7d4 Bug #30897: Simplify architecture handling 4531d33 Bug #30897: Reformat long regular expression c5e9283 Bug #30897: Rewrite loop logic edcfdb0 Bug #30897: Add value to ValueError() 04406d0 Bug #30897: Cleanup string formatting c35242f Bug #30897: Move domain target state variable f5f3b2d Bug #30897: Only import partial urlparse 1bd7a4a Bug #30897: Convert map() to list comprehension 62f1462 Bug #30897: White space cleanup 26347a8 Bug #30897: Add missing translations 768160d Bug #30897: Update inline documentation 51a8f3f Bug #30897: Dead code cleanup b2ff838 Bug #30897: Remove unused code 08686a7 Bug #21397: Fix remote root vulnerability facb192 Bug #21397: Cleanup exception handling ad02374 Bug #21397: Fix Storage+s+ naming 6bbe2b4 Bug #21397: Update copyright \item The internal code of UVMM was cleaned up (\ucsBug{30897}). errata3.1-1: Backport: svn40866..40890 univention-virtual-machine-manager-daemon_2.0.36-7.445.201305271400 univention-xen_4.0.0-4.66.201305271359 xen-4.1_4.1.3-9+1.34.201305271402 yaml: r40895 ucs-3.1-1/doc/errata/2013-05-27-univention-virtual-machine-manager-daemon.yaml ucs-3.1-1/doc/errata/2013-05-27-univention-xen.yaml ucs-3.1-1/doc/errata/2013-05-27-xen-4.1.yaml FAIL - changelog Why is the 3.2 changelog entry in the XEN section? Would it not make more sense in the UVMM section? FAIL - yaml -> grep 30897 * 2013-05-27-univention-virtual-machine-manager-daemon.yaml:bug: [30897, 30897] OK - I noticed nothing unusual in the operation of UVMM in errata3.1-1 and 3.2-0 (In reply to Felix Botner from comment #3) > FAIL - changelog > Why is the 3.2 changelog entry in the XEN section? Would it not make more > sense in the UVMM section? > > FAIL - yaml Verschoben nach UVMM Fixed svn41253 OK |
Created attachment 5150 [details] Cleanup JSHint issues JSHint found several minor issues in the JavaScript code of UVMM, which should be fixed. $ diffstat ~/BUG/UVMM-js-cleanup.diff DriveWizard.js | 6 +++--- InterfaceWizard.js | 2 +- SnapshotGrid.js | 2 +- types.js | 20 ++++++++++++-------- 4 files changed, 17 insertions(+), 13 deletions(-)