Univention Bugzilla – Full Text Bug Listing |
Summary: | Improve performance of App Center frontend: App Detail dialog can open instantly | ||
---|---|---|---|
Product: | UCS | Reporter: | Dirk Wiesenthal <wiesenthal> |
Component: | UMC - App-Center | Assignee: | Dirk Wiesenthal <wiesenthal> |
Status: | CLOSED FIXED | QA Contact: | Alexander Kläser <klaeser> |
Severity: | normal | ||
Priority: | P5 | CC: | gohmann, jmm, klaeser |
Version: | UCS 3.1 | ||
Target Milestone: | UCS 3.2-2-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: | |||
Attachments: | Simply remove the tools.umcpCommand('appcenter/get', {'application': app.id}) |
Description
Dirk Wiesenthal
2013-07-08 13:11:49 CEST
Created attachment 5307 [details]
Simply remove the tools.umcpCommand('appcenter/get', {'application': app.id})
Patch looks huge, but it is just indentation.
Patch has one drawback: Apps will not know that a new UUID license has been installed. One would still have to reload the app if (!app.allows_using) With the new App Center, where the "Install" button is always visible and the tests are run _after_ pressing it, this bug is relatively easy again. But the patch will not work. In some cases one can instantly open the dialog (in 3.2 it is more a full page), e.g. when clicking on an app from the App Center GalleryPane, in some cases one has to load the app from the server, e.g. when opening an "Installed App" module Fixed in univention-management-console-module-appcenter 3.0.51-16.250.201406031613 App is fetched from the host if only the id is given (happens in "Installed Apps" module or when clicking on "This app cannot be installed due to dependencies. Click here to install "$app" first"). But if the full app is known (AppGallery) this is not done anymore. In my tests it seems that ConflictedSystemPackages is not evaluated. Can you confirm this? (In reply to Alexander Kläser from comment #5) > In my tests it seems that ConflictedSystemPackages is not evaluated. Can you > confirm this? That was my mistake! Behaviour is fine, AFAIS: * open installed app from overview → details are loaded, app is displayed fine * open app within App Center → app is displayed immediately without loading data * open app within App Center → open required/conflicted app → details are loaded, app is displayed fine * open app within App Center → install app → cancel reload → app details are updated correctly (In reply to Dirk Wiesenthal from comment #0) > ... > I suggest sending those in the first place. It may slightely reduce > performance until the list shows up (not because of computations but because > of more bits being transferred - so I think it is *very slightely*). > But if this is done in the beginning, the opening of the app details can be > instant without asking the server. There is no real difference 126KB vs 127KB. YAML file → OK → VERIFIED |