Univention Bugzilla – Full Text Bug Listing |
Summary: | noVNC tab title should include VM Name | ||
---|---|---|---|
Product: | UCS | Reporter: | Erik Damrose <damrose> |
Component: | Virtualization - UVMM | Assignee: | Philipp Hahn <hahn> |
Status: | CLOSED FIXED | QA Contact: | Erik Damrose <damrose> |
Severity: | normal | ||
Priority: | P5 | CC: | best, gohmann, hahn, jmm |
Version: | UCS 3.2 | Flags: | hahn:
Patch_Available+
|
Target Milestone: | UCS 3.2-0-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | Usability | |
Max CVSS v3 score: | |||
Attachments: | Add URI-escaping for title |
Description
Erik Damrose
2013-11-06 18:18:00 CET
Please also the virtualization host! noVNC supports the query parameter "title": > document.title = unescape(WebUtil.getQueryVar('title', 'noVNC')); http://.../univention-novnc/vnc_auto.html?port=6080&path=?token=...&title=*** diff --git a/branches/ucs-3.2/ucs-3.2-0/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js b/branches/ucs-3.2/ucs-3.2-0/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js index 2cc4d98..55a1038 100644 --- a/branches/ucs-3.2/ucs-3.2-0/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js +++ b/branches/ucs-3.2/ucs-3.2-0/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js @@ -318,10 +318,12 @@ define([ }, vncLink: function( ids, items ) { - array.forEach(ids, function(id) { + array.forEach(items, function(item) { + var id = item.id; var uuid = id.slice(id.indexOf('#') + 1); var port = window.location.port ? ':' + window.location.port : ''; - var url = window.location.protocol + '//' + window.location.host + port + '/univention-novnc/vnc_auto.html?port=6080&path=?token=' + uuid; + var title = item.label + '@' + item.nodeName; + var url = window.location.protocol + '//' + window.location.host + port + '/univention-novnc/vnc_auto.html?port=6080&path=?token=' + uuid + '&title=' + title; window.open(url, '_blank'); }); }, Created attachment 5687 [details]
Add URI-escaping for title
As the title is user-supplied, it needs to be URI-escaped.
r47554 | Bug #33164: UVMM: Set title on noVNC to VM name and host r47557 | Bug #33164: UVMM: Set title on noVNC to VM name and host [YAML] Package was built on ladda using --force-arch, since dimma is offline. *_amd64.changes was hard-linked to *_i386.changes to satisfy "announce_errata -V". OK: YAML OK: Title is set in the noVNC URL parameters OK: Title is shown in noVNC tabs noVNC does not decode umlauts and other special characters correctly -> Bug 34030 -> Verified |