Bug 33443

Description Alexander Kläser 2013-11-18 09:21:13 CET

Currently, the updater module does not handle 401 (=unauthorized) errors correctly, therefore the login dialogue is not opened if the UMC server is restarted in the update process.

The problem is in the method umc/modules/updater:handleQueryError(). The handling is not correct:

> handleQueryError: function(subject, data) {
>     ...
>     if (data.status == 401) { ... }
>     ...
> }

At this point "data" has the following structure:

> {
>   "stack": "...",
>   "message": "Unable to load /umcp/command/updater/installer/status status: 401",
>   "response": {
>     "url": "/umcp/command/updater/installer/status",
>     "options": {
>       "method": "POST",
>       "data": "{\"options\":{\"job\":\"distupgrade\"}}",
>       "handleAs": "json",
>       "headers": {
>         "Content-Type": "application/json"
>       }
>     },
>     "xhr": {
>       "statusText": "Unauthorized",
>       "status": 401,
>       "response": "{\"status\": 401, \"message\": \"None\"}",
>       "responseType": "",
>       "responseXML": null,
>       "responseText": "{\"status\": 401, \"message\": \"None\"}",
>       "upload": {
>         "onprogress": null,
>         "onloadstart": null,
>         "onloadend": null,
>         "onload": null,
>         "onerror": null,
>         "onabort": null
>       },
>       "withCredentials": false,
>       "readyState": 4,
>       "timeout": 0,
>       "onreadystatechange": null,
>       "ontimeout": null,
>       "onprogress": null,
>       "onloadstart": null,
>       "onloadend": null,
>       "onload": null,
>       "onerror": null,
>       "onabort": null
>     },
>     "loaded": 34,
>     "total": 34,
>     "status": 401,
>     "text": "{\"status\": 401, \"message\": \"None\"}",
>     "data": {
>       "status": 401,
>       "message": "None"
>     }
>   }
> }

Correct would be data.response.status == 401. However, even more correct would be to use the UMC wide error handling.