Univention Bugzilla – Full Text Bug Listing |
Summary: | UDM module process dies when response contains binary data | ||
---|---|---|---|
Product: | Z_FUKITS | Reporter: | Alexander Kläser <klaeser> |
Component: | univention-bittorrent | Assignee: | Felix Botner <botner> |
Status: | CLOSED FIXED | QA Contact: | Daniel Orrego <orrego> |
Severity: | normal | ||
Priority: | P5 | CC: | best, steuwer |
Version: | unstable | ||
Target Milestone: | 3.1 RC1 | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: |
Description
Alexander Kläser
2013-11-21 17:10:13 CET
Janek, how many tools need to be changed if we'd store the hash base64 encoded? (In reply to Ingo Steuwer from comment #1) > Janek, how many tools need to be changed if we'd store the hash base64 > encoded? Complete univention-bittorrent/ - that is the "library" must be changed and every tool tested. Also 33⅓% space overhead. I'd much rather see UDM/UMC fixed. The real problem is > File > "/usr/lib/pymodules/python2.6/univention/management/console/protocol/message. > py", line 119, in _formattedMessage > data = json.dumps( body ) giving trying to encode data of a type (bytes) that JSON cannot store || giving a <str> object instead of a <unicode> object to the json library > File "/usr/lib/pymodules/python2.6/simplejson/__init__.py", line 261, in > dumps > return _default_encoder.encode(obj) leading to the json library interpreting it as encoded text || leading to the json library having to guess/assume an encoding of some byte string > UnicodeDecodeError: 'utf8' codec can't decode byte 0xc6 in position 197: > invalid continuation byte and thus failing. (In reply to Janek Walkenhorst from comment #2) > (In reply to Ingo Steuwer from comment #1) > > Janek, how many tools need to be changed if we'd store the hash base64 > > encoded? > Complete univention-bittorrent/ - that is the "library" must be changed and > every tool tested. > > Also 33⅓% space overhead. > > I'd much rather see UDM/UMC fixed. Yes, that would be the "right" way (I agreed to that in a discussion earlier yesterday with Alex), that's Bug 33520. But we shouldn't fork UDM and UMC to implement a component, because it would generate much more work and maybe problems in the long term. Felix, please change the handling to base64 encoded binaries in the lib. As long as we don't reach the RC1 we don't need backward compatibility. univention-bittorrent now saves the torrent attriubte as base64 encoded string. Verified. |