Bug 33527
| Summary: | No proper error message if IP address pool is empty | ||
|---|---|---|---|
| Product: | UCS | Reporter: | Alexander Kläser <klaeser> |
| Component: | UMC - Computers | Assignee: | Drees Dormann <dormann> |
| Status: | CLOSED FIXED | QA Contact: | Florian Best <best> |
| Severity: | normal | ||
| Priority: | P5 | CC: | best, gohmann, walkenhorst, walter, wiesenthal |
| Version: | UCS 3.0 | ||
| Target Milestone: | UCS 4.0-0-errata | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| What kind of report is it?: | --- | What type of bug is this?: | --- |
| Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
| User Pain: | Enterprise Customer affected?: | ||
| School Customer affected?: | ISV affected?: | ||
| Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
| Ticket number: | Bug group (optional): | Error handling, External feedback, Usability | |
| Max CVSS v3 score: | |||
| Attachments: | patch | ||
*** Bug 29285 has been marked as a duplicate of this bug. *** Reported by traceback feedback Reported again And again Traceback has been replaced with a proper "user friendly" error message containing informations for the user. (r 56913) Created attachment 6550 [details]
patch
Your fix looks good! I have some fine tuning ideas attached in the patch. Can you please apply it?
FYI: explodeDn has a second parameter "notypes" which already does what you want (only displaying the name without the dn part):
The following statement can then be reduced:
(udm.uldap.explodeDn(networkDN)[0]).split('=')[1]
→
udm.uldap.explodeDn(ldap_dn, True)[0]
thx for the suggestion, patch has been applied Here some small typos in the german translation (marked with »«): Fehler »beim der« automatischen »IP Adressen Zuweisung«. Alle IP Adressen »in dem« gewählten Netzwerk "default" sind schon in Benutzung. Bitte wählen Sie ein anderes Netzwerk oder stellen Sie sicher» das« ungenutzte IP Adressen zur Verfügung stehen. "zur Verfügung stehen" → "im gewählten Netzwerk zur Verfügung stehen" Fixed the typos and adapted the error message to be more specific (r 57127) (In reply to Drees Dormann from comment #9) > Fixed the typos and adapted the error message to be more specific > (r 57127) OK, (I fixed choosen → chosen, and a missing ','). |
I have 253 computers in the domain with a /24 size network. Upon creating a new one and assigning an IP address automatically, I receive the following error instead of a proper user friendly error message: Execution of command 'udm/network' has failed: Traceback (most recent call last): File "/usr/lib/pymodules/python2.6/univention/management/console/modules/__init__.py", line 204, in execute func( request ) File "/usr/lib/pymodules/python2.6/univention/management/console/modules/udm/__init__.py", line 577, in network obj.refreshNextIp() File "/usr/lib/pymodules/python2.6/univention/admin/handlers/networks/network.py", line 237, in refreshNextIp raise univention.admin.uexceptions.nextFreeIp nextFreeIp