Bug 34321
| Summary: | uvmmd-check.sh uses "kill" instead of "kill -9" | ||
|---|---|---|---|
| Product: | UCS | Reporter: | Tim Petersen <petersen> |
| Component: | Virtualization - UVMM | Assignee: | Erik Damrose <damrose> |
| Status: | CLOSED FIXED | QA Contact: | Philipp Hahn <hahn> |
| Severity: | normal | ||
| Priority: | P3 | CC: | gohmann, hahn, jmm |
| Version: | UCS 3.2 | ||
| Target Milestone: | UCS 3.2-1-errata | ||
| Hardware: | All | ||
| OS: | Linux | ||
| What kind of report is it?: | --- | What type of bug is this?: | --- |
| Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
| User Pain: | Enterprise Customer affected?: | ||
| School Customer affected?: | ISV affected?: | ||
| Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
| Ticket number: | Bug group (optional): | Large environments, Troubleshooting, UCS Performance | |
| Max CVSS v3 score: | |||
| Bug Depends on: | 33741 | ||
| Bug Blocks: | |||
|
Description
Tim Petersen
Since "runit" is in between, perhaps "force-stop" and/or "force-restart" should be used. (man 8 sv) FYI: non-runit-init-scripts use something like this: start-stop-daemon --stop --quiet --retry=TERM/30/KILL/5 The 'kill' command mentioned in comment 0 refers to the script uvmmd-check.sh. The script tries to determine the uvmm_d_ status by executing an uvmm command and waiting for its output. As the uvmm command writes and reads from the uvmm_d_ socket, it can easily be 'kill'ed. Uvmm_d_ is then restarted by calling its initscript. Here, the uvmm_d_ that does not terminate because of a blocking FUTEX. The initscript now uses force-restart and force-stop: univention-virtual-machine-manager-daemon 3.0.17-6.489.201403131114 2014-03-13-univention-virtual-machine-manager-daemon.yaml OK: Upgrade OK: sed -i '/signal.SIGTERM/s/signal_handler_terminate/signal.SIG_IGN/' /usr/sbin/univention-virtual-machine-manager-daemon kill -STOP $(</etc/runit/univention-virtual-machine-manager-daemon/supervise/pid) bash -x /etc/init.d/univention-virtual-machine-manager-daemon restart # terminates with old and new version kill -STOP $(</etc/runit/univention-virtual-machine-manager-daemon/supervise/pid) bash -x /etc/init.d/univention-virtual-machine-manager-daemon restart # only terminates with new version OK: $EDITOR /usr/lib/univention-virtual-machine-manager-daemon/uvmmd-check.sh exec >>"$logfile" 2>&1 set -x kill -STOP $(</etc/runit/univention-virtual-machine-manager-daemon/supervise/pid) tail -f /var/log/univention/virtual-machine-manager-daemon-errors.log + echo 'uvmm-check.sh: uvmm does not response like expected. Restarting uvmmd now.' + invoke-rc.d univention-virtual-machine-manager-daemon restart === 21194 === Thu, 13 Mar 2014 16:18:24 +0100 === OK: r48485 RFA r48488: s/support blocked processes/handle blocked UVMMd processes./ OK: announce_errata -V 2014-03-13-univention-virtual-machine-manager-daemon.yaml (In reply to Philipp Hahn from comment #3) > RFA r48488: s/support blocked processes/handle blocked UVMMd processes./ r48548: yaml wording improved |