Bug 34916

Summary: Directory-logger: Traceback delist
Product: UCS Reporter: Philipp Hahn <hahn>
Component: LDAPAssignee: Philipp Hahn <hahn>
Status: CLOSED FIXED QA Contact: Felix Botner <botner>
Severity: normal    
Priority: P5 CC: best, gohmann, schwardt
Version: UCS 4.2   
Target Milestone: UCS 4.1-3-errata   
Hardware: Other   
OS: Linux   
What kind of report is it?: Bug Report What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 2: Will only affect a few installed domains How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.069 Enterprise Customer affected?: Yes
School Customer affected?: ISV affected?: Yes
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: Bug group (optional): External feedback
Max CVSS v3 score:
Attachments: 34916.diff

Description Philipp Hahn univentionstaff 2014-05-22 11:43:12 CEST
Traceback (most recent call last):
  File "/usr/lib/univention-directory-listener/system/directory_logger.py", line 232, in handler
    (timestamp, dellog_id, modifier, action) = process_dellog( dn )
  File "/usr/lib/univention-directory-listener/system/directory_logger.py", line 122, in process_dellog
    filename = dellist.pop(0);
IndexError: pop from empty list
LISTENER    ( WARN    ) : at least one delete handler failed

Traceback (most recent call last):
  File "/usr/lib/univention-directory-listener/system/directory_logger.py", line 191, in handler
    process_dellog( dn )
  File "/usr/lib/univention-directory-listener/system/directory_logger.py", line 160, in process_dellog
    if not modifier:    # Fallback
UnboundLocalError: local variable 'modifier' referenced before assignment
LISTENER    ( WARN    ) : at least one delete handler failed
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2015-02-11 13:23:47 CET
Both tracebacks have been found on a customer system.
Comment 2 Sönke Schwardt-Krummrich univentionstaff 2016-08-01 14:16:18 CEST
*** Bug 38007 has been marked as a duplicate of this bug. ***
Comment 3 Sönke Schwardt-Krummrich univentionstaff 2016-08-01 14:34:27 CEST
The second traceback has been recently found a several hundred times in listener.log when moving user objects. Because of this the directory logger cannot be used to debug another LDAP problem.
Comment 4 Philipp Hahn univentionstaff 2016-10-13 11:45:30 CEST
r73119 | Bug #34916 log: Do not remove work directory on updates
r73118 | Bug #34916 log: Fix tracebacks in dellog processing
r73114 | Bug #34916 log: Stop cloning old and new
r73113 | Bug #34916 log: Rename debian/ files
r73112 | Bug #34916 log: autopep8

Package: univention-directory-logger
Version: 7.0.1-2.39.201610131121
Branch: ucs_4.1-0
Scope: errata4.1-3

r73133 | Bug #34916 log: Do not remove work directory on updates
r73132 | Bug #34916 log: Fix tracebacks in dellog processing
r73129 | Bug #34916 log: Stop cloning old and new
r73128 | Bug #34916 log: Rename debian/ files
r73127 | Bug #34916 log: autopep8

r73141 | Bug #25404,Bug #34916,Bug #34420,Bug #42665: univention-directory-logger YAML
 univention-directory-logger.yaml
Comment 5 Philipp Hahn univentionstaff 2016-10-17 14:31:53 CEST
Created attachment 8118 [details]
34916.diff

65711e6 Bug #34916 log: Do not remove work directory on updates
4c711a3 Bug #34916 log: Fix tracebacks in dellog processing
Comment 6 Philipp Hahn univentionstaff 2016-10-21 12:52:27 CEST
r73440 | Bug #34916 log: Remove message from dellog processing
r73439 | Bug #34916 log: Remove message from dellog processing

Package: univention-directory-logger
Version: 7.0.1-3.40.201610211249
Branch: ucs_4.1-0
Scope: errata4.1-3

r73441 | Bug #34916 log: Remove message from dellog processing YAML
 univention-directory-logger.yaml
Comment 7 Felix Botner univentionstaff 2016-10-21 14:42:11 CEST
OK - rename debian files
OK - autopep8
OK - stop cloning old and new
OK - fix tracebacks in dellog processing  (create, move, delete of 500 users,
     no errors)
OK - Do not remove work directory on updates

OK - yaml
OK - merged to 4.2
Comment 8 Janek Walkenhorst univentionstaff 2016-10-26 17:09:02 CEST
<http://errata.software-univention.de/ucs/4.1/317.html>