Bug 35865
| Summary: | Connector rejected check | ||
|---|---|---|---|
| Product: | UCS | Reporter: | Stefan Gohmann <gohmann> |
| Component: | UMC - System diagnostic | Assignee: | Lukas Oyen <oyen> |
| Status: | CLOSED FIXED | QA Contact: | Arvid Requate <requate> |
| Severity: | enhancement | ||
| Priority: | P5 | CC: | best, oyen, requate |
| Version: | UCS 4.0 | Flags: | oyen:
Patch_Available+
|
| Target Milestone: | UCS 4.2-2-errata | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| What kind of report is it?: | --- | What type of bug is this?: | --- |
| Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
| User Pain: | Enterprise Customer affected?: | ||
| School Customer affected?: | ISV affected?: | ||
| Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
| Ticket number: | Bug group (optional): | ||
| Max CVSS v3 score: | |||
| Attachments: |
35865-diagnostic-s4rejects-420.tar
35865-diagnostic-s4rejects.png 8859: 35865-diagnostic-s4rejects-420.tar |
||
|
Description
Stefan Gohmann
Created attachment 8859 [details]
35865-diagnostic-s4rejects-420.tar
The attached patches implement the S4 Connector rejected checked similar to `univention-s4connector-list-rejected`. It does not use this tool directly to avoid string parsing.
If the S4 Connector is not an active service, this simply skips the checks. It might be better to implement a module-level callback `is_disabled()` or something, that lets the `Instance` class filter the active checks.
- If the service is running, but `univention.s4connector.s4` fails to import, a CRITICAL error is raised.
- If any of the necessary UCR variables to instantiate the `s4()` class are not set, a CRITICAL error is raised.
- If any rejects are found a WARNING is raised.
Created attachment 8860 [details]
35865-diagnostic-s4rejects.png
Example reject report.
1. load_mapping() should use try-finally.
2. an empty '%(configbase)s/s4/ldap/bindpw' file will cause an exception. Better:
s4_ldap_bindpw = fob.read().rstrip()
3. leading white space in visible string: 'label': _(' Univention Support Database
Created attachment 8864 [details]
8859: 35865-diagnostic-s4rejects-420.tar
Updated patches.
Committed in r81607 - r81608 (advisory r81649). Ok, works. |