Univention Bugzilla – Full Text Bug Listing |
Summary: | "Invalid smb.conf" output by testparm | ||
---|---|---|---|
Product: | UCS | Reporter: | Arvid Requate <requate> |
Component: | Samba | Assignee: | Arvid Requate <requate> |
Status: | CLOSED FIXED | QA Contact: | Felix Botner <botner> |
Severity: | normal | ||
Priority: | P5 | CC: | gohmann, grandjean, michael, walkenhorst |
Version: | UCS 4.0 | ||
Target Milestone: | UCS 4.0-3-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: |
Description
Arvid Requate
2014-11-11 23:08:48 CET
Looks like this is the issue: winbind separator = + And this is where it comes from in python/samba/netcmd/testparm.py: if winbind_separator == '+': logger.error( "'winbind separator = +' might cause problems with group " "membership.") valid = False So we have three options: a) ignore the message b) patch the code c) change the parameter value (e.g. make it adjustable via UCR). (In reply to Arvid Requate from comment #1) > Looks like this is the issue: > > winbind separator = + > > And this is where it comes from in python/samba/netcmd/testparm.py: > > if winbind_separator == '+': > logger.error( > "'winbind separator = +' might cause problems with group " > "membership.") > valid = False > > So we have three options: > > a) ignore the message > b) patch the code > c) change the parameter value (e.g. make it adjustable via UCR). I vote for c). This is a minor issue, I think it's not worth changing the winbind separator now. I patched python/samba/netcmd/testparm.py instead, to issue a warning instead of an error. I guess this might even get accepted upstream. Changelog adjusted. Ah, this is errata4.0-3, so I've merged the patch from 4.1 to errata4.0-3 and rebuilt samba there as well. I removed the UCS 4.1 changelog and added a yaml advisory instead. OK - errata4-0-3 OK - 4.1-0 OK - YAML |