Univention Bugzilla – Full Text Bug Listing |
Summary: | VNC access icon half hidden | ||
---|---|---|---|
Product: | UCS | Reporter: | Jan Christoph Ebersbach <ebersbach> |
Component: | UMC - Virtual machines (UVMM) | Assignee: | Johannes Keiser <keiser> |
Status: | CLOSED FIXED | QA Contact: | Alexander Kläser <klaeser> |
Severity: | normal | ||
Priority: | P5 | CC: | best, damrose, gohmann, klaeser, peichert, walkenhorst |
Version: | UCS 4.0 | ||
Target Milestone: | UCS 4.0-1-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
See Also: |
https://forge.univention.org/bugzilla/show_bug.cgi?id=27041 https://forge.univention.org/bugzilla/show_bug.cgi?id=32027 |
||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: | |||
Attachments: |
VNC access icon half hidden
Fix width of textbox Screenshot UVMM grid header |
Will be fixed when we convert to dgrid (Bug #32027) Created attachment 6718 [details]
Fix width of textbox
In addition to this design fix, please change the width of the 'Query pattern' textbox to one, see patch
Johannes, can you have a look at this. It can be fixed with a workaround maybe by adding a invisible empty column at the very right, e.g.: { name: 'spacer', label: ' ', width: 'adjust', formatter: function() { return ''; } } The problem here is the width specification of the column: { name: 'vnc', label: _('View'), width: 'adjust', ... } "adjust" means that the width is adjusted to the header label width. The English label "View" is too narrow, so the button is cut off. It would be easier to specify a fixed width, e.g., in em for all the columns which contain a button. (In reply to Alexander Kläser from comment #4) > The problem here is the width specification of the column: > > { > name: 'vnc', > label: _('View'), > width: 'adjust', > ... > } > > "adjust" means that the width is adjusted to the header label width. The > English label "View" is too narrow, so the button is cut off. It would be > easier to specify a fixed width, e.g., in em for all the columns which > contain a button. Fixed: r59551 univention-virtual-machine-manager-daemon (4.0.24-4): Bug #36678: * Fixed VNC acces beeing half hidden in firefox. yaml: r59555 Created attachment 6809 [details] Screenshot UVMM grid header It looks better! A minor thing can be seen in the screenshot attached... in Chromium, the 50px are too narrow for the German word "Anzeigen". Could you please adjust the debian changelog entry to the following (including some adjusted typos): > * Bug #36678: Fixed icon for VNC access to be fully visible in Firefox. > * Bug #38010: Fixed an endless loop for refreshing grid and tree view if > no connection is available. Please adjust the YAML file entries, a suggestion from my side would be: > * A display error of the icon for VNC access in Firefox has been corrected > in the UMC module. > * An error in the grid of the UMC module resulted in an endless refreshing > loop of the grid if no connection was available. This has been adjusted. ... please adapt this suggestion to your liking :) . (In reply to Alexander Kläser from comment #6) > Created attachment 6809 [details] > Screenshot UVMM grid header > > It looks better! A minor thing can be seen in the screenshot attached... in > Chromium, the 50px are too narrow for the German word "Anzeigen". > > Could you please adjust the debian changelog entry to the following > (including some adjusted typos): > > > * Bug #36678: Fixed icon for VNC access to be fully visible in Firefox. > > * Bug #38010: Fixed an endless loop for refreshing grid and tree view if > > no connection is available. > > Please adjust the YAML file entries, a suggestion from my side would be: > > > * A display error of the icon for VNC access in Firefox has been corrected > > in the UMC module. > > * An error in the grid of the UMC module resulted in an endless refreshing > > loop of the grid if no connection was available. This has been adjusted. > > ... please adapt this suggestion to your liking :) . Adjusted: r59620 * Bug #36678: adjusted the width of the 'vnc' column in the uvmm umc module yaml: r59621 Changes: OK, look good. YAML file: OK, looks good. → VERIFIED |
Created attachment 6371 [details] VNC access icon half hidden On Firefox 33.1 the VNC access icon is half hidden by a scrollbar. It's not clear why there is a scrollbar in the first place because all VMs fit into the window.