Bug 37343

Summary: samba restart leaving behind an stuck samba daemon
Product: UCS Reporter: Arvid Requate <requate>
Component: Samba4Assignee: Arvid Requate <requate>
Status: CLOSED FIXED QA Contact: Stefan Gohmann <gohmann>
Severity: normal    
Priority: P5 CC: gohmann, walkenhorst
Version: UCS 4.0   
Target Milestone: UCS 4.0-0-errata   
Hardware: Other   
OS: Linux   
What kind of report is it?: --- What type of bug is this?: ---
Who will be affected by this bug?: --- How will those affected feel about the bug?: ---
User Pain: Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: Bug group (optional):
Max CVSS v3 score:
Bug Depends on:    
Bug Blocks: 37342    

Description Arvid Requate univentionstaff 2014-12-15 12:52:22 CET 
On an internal system 37342  a singkee samba was stuck after a restart, which in turn left the system unusable, causing all kinds of side effects.

While it's unclear why the man samba process didn't terminate on request, we need to adjust the init script to absolutely ensure that samba is working after a restart. We used to have this, but it's been removed in the transition to UCS 4.0:

The idea was that this line in /etc/init.d/samba-ad-dc would finally kill samba:

start-stop-daemon --stop --quiet --pidfile /var/run/samba/samba.pid --name samba --retry TERM/15/KILL/1 -v

But apparently it doesn't do it in this case:

root@master:~# cat /var/run/samba/samba.pid       
cat: /var/run/samba/samba.pid: Datei oder Verzeichnis nicht gefunden

root@master:~# start-stop-daemon --stop --quiet --name samba --retry TERM/15/KILL/1 -v                      Stopped samba (pid 4924).
Stopped samba (pid 4924), retry #1.

So, we should make that start-stop-daemon use "-x /usr/sbin/samba" instead of filtering for the PID.
Comment 1 Arvid Requate univentionstaff 2014-12-15 13:02:11 CET 
> On an internal system 37342  a singkee samba was stuck after a restart

translated into english:


On an internal system a single samba process was stuck after a restart  (see Bug 37342)
Comment 2 Arvid Requate univentionstaff 2015-01-07 18:21:38 CET 
Advisory: 2014-12-08-samba.yaml
Comment 3 Stefan Gohmann univentionstaff 2015-01-14 13:43:56 CET 
YAML: OK

Tests: OK

ucs-test: OK

Code review: OK
Comment 4 Janek Walkenhorst univentionstaff 2015-01-15 12:50:54 CET 
<http://errata.univention.de/ucs/4.0/32.html>