Bug 37388

Summary:	S4 connector does not support renaming windows clients
Product:	UCS	Reporter:	Felix Botner <botner>
Component:	S4 Connector	Assignee:	Arvid Requate <requate>
Status:	CLOSED FIXED	QA Contact:	Felix Botner <botner>
Severity:	normal
Priority:	P2	CC:	best, gohmann, grandjean, requate
Version:	UCS 4.0	Flags:	requate: Patch_Available+
Target Milestone:	UCS 4.1-4-errata
Hardware:	Other
OS:	Linux
See Also:	https://forge.univention.org/bugzilla/show_bug.cgi?id=39802 https://forge.univention.org/bugzilla/show_bug.cgi?id=31083 https://forge.univention.org/bugzilla/show_bug.cgi?id=37389 https://forge.univention.org/bugzilla/show_bug.cgi?id=42396
What kind of report is it?:	Bug Report	What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	2: Will only affect a few installed domains	How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.114	Enterprise Customer affected?:	Yes
School Customer affected?:		ISV affected?:
Waiting Support:		Flags outvoted (downgraded) after PO Review:
Ticket number:	2016102821000806	Bug group (optional):
Max CVSS v3 score:
Attachments:	windowscomputer_sync_s4_to_ucs_check_rename.patch

Description Felix Botner

2014-12-18 11:17:35 CET

Renaming a joined windows client is not supported by the s4 connector at the moment.

If renamed, computer objects get an new samAccountName and display name in s4 but not in UCS. We may need a kind of post_modify function for windowscomputer to change the at least the uid of the UCS object (maybe we should change the cn/dn too?).

QA/Tests:

After the computer was renamed the uid/samaccountname attributes and the SID's should be the same.
gpupdate on the windows client should be possible.
After gpupdate "smbstatus" on the UCS server should display the correct (new) computer name.

Comment 1 Felix Botner

2014-12-18 11:18:00 CET

*** Bug 36762 has been marked as a duplicate of this bug. ***

Comment 2 Arvid Requate

2016-03-22 19:10:47 CET

*** Bug 39883 has been marked as a duplicate of this bug. ***

Comment 3 Arvid Requate

2016-03-22 19:27:12 CET

Please also note Bug 31083 Comment 8:

==============================================================================
Difference between renaming in AD and Samba:

During rename of a computer in AD, all attributes of the computer object are modified (dn, cn, name, displaName, sAMAccountname, ...). But in Samba dn, cn, and name are not modified!
==============================================================================

Comment 4 Arvid Requate

2016-03-23 18:51:36 CET

*** Bug 40938 has been marked as a duplicate of this bug. ***

Comment 5 Arvid Requate

2016-03-23 18:51:53 CET

Workaround (at the time of writing):

## If "$newname" is the new client name without trailing $-sign:

udm computers/windows modify --dn "$windowsclient" --set name="$newname"

Comment 6 Arvid Requate

2016-11-09 13:26:33 CET

Created attachment 8207 [details]
windowscomputer_sync_s4_to_ucs_check_rename.patch

This post_ucs_modify_function for 'windowscomputers' automatizes the UDM rename of Comment 5.

Comment 7 Arvid Requate

2016-11-17 14:40:42 CET

Advisory: univention-s4-connector.yaml

Comment 8 Felix Botner

2016-11-22 12:03:43 CET

* i always get 

  Renaming client from [u'WIN8PRO'] to WIN8PRO

 seems that the test if cn has been changed is not correct 

* please merge to 4.2-0

Comment 9 Arvid Requate

2016-11-22 12:38:24 CET

Fixed, merged and built, advisory updated.

Comment 10 Felix Botner

2016-11-22 14:44:23 CET

OK - renaming via windows client (ldap s4 cn, uid sAMAccountName in sync)
OK - winxp, win8, win7
OK - gpupdate /force, smbstatus
OK - merged to 4.2-0
OK - YAML

Comment 11 Felix Botner

2016-11-23 13:08:13 CET

see https://forge.univention.org/bugzilla/show_bug.cgi?id=40435#c8

is this a side effect of the s4 connector changes?

Comment 12 Florian Best

2016-11-23 13:19:17 CET

svn r74663 makes uid.rstrip('$')

Comment 13 Arvid Requate

2016-11-23 13:30:20 CET

> is this a side effect of the s4 connector changes?

No it's not.

> svn r74663 makes uid.rstrip('$')

Yes, to obtain the expected_cn. What's wrong about that?

Comment 14 Florian Best

2016-11-23 13:42:28 CET

(In reply to Arvid Requate from comment #13)
> > is this a side effect of the s4 connector changes?
> 
> No it's not.
> 
> > svn r74663 makes uid.rstrip('$')
> 
> Yes, to obtain the expected_cn. What's wrong about that?
Nothing :) I just thought it could be in relation with 40435#c8.

Comment 15 Felix Botner

2016-11-28 13:19:24 CET

(In reply to Arvid Requate from comment #13)
> > is this a side effect of the s4 connector changes?
> 
> No it's not.
> 
> > svn r74663 makes uid.rstrip('$')
> 
> Yes, to obtain the expected_cn. What's wrong about that?

OK

Comment 16 Janek Walkenhorst

2016-12-01 11:57:21 CET

<http://errata.software-univention.de/ucs/4.1/345.html>