Univention Bugzilla – Full Text Bug Listing |
Summary: | Don't allow share names with consecutive whitespaces | ||
---|---|---|---|
Product: | UCS | Reporter: | Janis Meybohm <meybohm> |
Component: | UMC - Shares | Assignee: | Florian Best <best> |
Status: | CLOSED FIXED | QA Contact: | Felix Botner <botner> |
Severity: | normal | ||
Priority: | P5 | CC: | best, botner, gohmann, markus.daehlmann, requate, scheinig |
Version: | UCS 4.1 | ||
Target Milestone: | UCS 4.2-2-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
See Also: |
https://forge.univention.org/bugzilla/show_bug.cgi?id=45375 https://forge.univention.org/bugzilla/show_bug.cgi?id=53880 |
||
What kind of report is it?: | Bug Report | What type of bug is this?: | 5: Major Usability: Impairs usability in key scenarios |
Who will be affected by this bug?: | 1: Will affect a very few installed domains | How will those affected feel about the bug?: | 5: Blocking further progress on the daily work |
User Pain: | 0.143 | Enterprise Customer affected?: | Yes |
School Customer affected?: | Yes | ISV affected?: | |
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | 2017021021000308, 2017033121000455, 2017090521000618 | Bug group (optional): | External feedback, Troubleshooting |
Max CVSS v3 score: | |||
Bug Depends on: | |||
Bug Blocks: | 38689, 45338 |
Description
Janis Meybohm
2015-06-11 17:55:33 CEST
In Ticket# 2017021021000308 we had a share configured with double spaces. In this case the UMC should not allow this. In Ticket# 2017033121000455 we had a share configured with double spaces again. This causes the 'samba-tool drs showrepl' to fail with the following error message: root@ucsschool:~# samba-tool drs showrepl ERROR(runtime): uncaught exception - Unable to load default file File "/usr/lib/python2.7/dist-packages/samba/netcmd/__init__.py", line 176, in _run return self.run(*args, **kwargs) File "/usr/lib/python2.7/dist-packages/samba/netcmd/drs.py", line 126, in run self.lp = sambaopts.get_loadparm() File "/usr/lib/python2.7/dist-packages/samba/getopt.py", line 92, in get_loadparm self._lp.load_default() Happens again in a school customer environment and it broke the school DC: Tiket #2017090521000618. I fixed this by encoding the files with urlencoding. The postinst contains a listener resync. If this is not okay then REOPEN and I will add update code with "mv" to the postinst which encodes all existing filenames. univention-samba (11.0.1-11): r82698 | Bug #38688: encode filesystem path of shares univention-samba.yaml: r82699 | YAML Bug #38688 (In reply to Florian Best from comment #5) > I fixed this by encoding the files with urlencoding. > The postinst contains a listener resync. If this is not okay then REOPEN and > I will add update code with "mv" to the postinst which encodes all existing > filenames. yes, i dont like this resync, is there a way to change the listener without touching the existing config? Do we need this for 4.1-4 also? (In reply to Felix Botner from comment #7) > Do we need this for 4.1-4 also? no (only univention-samba4) Ok, it's manually done in postinst now: univention-samba (11.0.1-12): 2ed82d5ec081f81ee6e359bdf3d4889b73953a3a | Merge branch 'fbest/38688-samba3-share-name-escaping' into 4.2-2 e497652d599026dbf1b986a81571af51f716c15c | Bug #38688: don't listener resync OK - YAML OK - share names OK - update please 1 to version (errata4.2-1) in the yaml file 71e28d4c96a53bb88723eb32bc6e989d52729777 | YAML Bug #38688 (In reply to Florian Best from comment #12) > 71e28d4c96a53bb88723eb32bc6e989d52729777 | YAML Bug #38688 ok |