Bug 39042
| Summary: | Improve rendering of button on app detail page | ||
|---|---|---|---|
| Product: | UCS | Reporter: | Alexander Kläser <klaeser> |
| Component: | UMC - App-Center | Assignee: | Alexander Kläser <klaeser> |
| Status: | CLOSED FIXED | QA Contact: | Dirk Wiesenthal <wiesenthal> |
| Severity: | normal | ||
| Priority: | P5 | CC: | walkenhorst |
| Version: | UCS 4.0 | ||
| Target Milestone: | UCS 4.0-2-errata | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| What kind of report is it?: | --- | What type of bug is this?: | --- |
| Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
| User Pain: | Enterprise Customer affected?: | ||
| School Customer affected?: | ISV affected?: | ||
| Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
| Ticket number: | Bug group (optional): | Usability | |
| Max CVSS v3 score: | |||
| Attachments: | Sample screenshots of new button arrangement. | ||
|
Description
Alexander Kläser
Created attachment 7070 [details] Sample screenshots of new button arrangement. Fixed. See the screenshot of some sample screenshots attached. 2015-05-28-univention-management-console-module-appcenter.yaml: r62506 | Bug #39042: added YAML entry univention-management-console-module-appcenter (4.1.20-40): r62505 | Bug #39042: improve the display of buttons on an app detail page Merge into 4.1-0 branch. univention-management-console-module-appcenter (5.0.0-1): r62507 | Bug #39042: improve the display of buttons on an app detail page @Dirk: Can you do the QA for this bug? BTW, I also replace the (x) button with a (←) button if an app is opened. OK, looks fine.
Minor issues:
* "Open" label is now webinterface ? "Open website" : "Open module"
but code is: module ? module.open() : website.open()
see nagios or agorum
* Could you use this new "Open" label for the "Installations thoughout the domain", too? Maybe put the code into App.js?
* (super minor) Currently no problems, but I would like to note that umcAppButtonFirstRow does not work as expected if you do not group those buttons:
buttons: [buttonWithFirstRow1, buttonWithoutFirstRow1, buttonWithFirstRow2] will not render the last button on the first row.
As this is no problem right now and more buttons are unlikely to be added that would break the layout, this can be ignored.
(In reply to Alexander Kläser from comment #4)
> BTW, I also replace the (x) button with a (←) button if an app is opened.
Nice!
(In reply to Dirk Wiesenthal from comment #5) > OK, looks fine. > > Minor issues: > * "Open" label is now webinterface ? "Open website" : "Open module" > but code is: module ? module.open() : website.open() > see nagios or agorum > * Could you use this new "Open" label for the "Installations thoughout the > domain", too? Maybe put the code into App.js? Jep, good hint, I adjusted this behaviour. Nagios app opens what is written on the button label now. The code has been put into App.js (getOpenLabel()). > * (super minor) Currently no problems, but I would like to note that > umcAppButtonFirstRow does not work as expected if you do not group those > buttons: > buttons: [buttonWithFirstRow1, buttonWithoutFirstRow1, > buttonWithFirstRow2] will not render the last button on the first row. > As this is no problem right now and more buttons are unlikely to be added > that would break the layout, this can be ignored. Ok. I will ignore this ;) . Packages are building, changes have been merged to 4.1-0. YAML file has not been updated- univention-management-console-module-appcenter (4.1.20-46): r62650 | Bug #39042: adjusted button labeling univention-management-console-module-appcenter (5.0.1-1): r62651 | Bug #39042: adjusted button labeling (In reply to Alexander Kläser from comment #6) > Ok. I will ignore this ;) . > > Packages are building, changes have been merged to 4.1-0. YAML file has not > been updated- Done. 2015-05-28-univention-management-console-module-appcenter.yaml: r62652 | Bug #39042: adapted package version Code: OK YAML: OK |