Univention Bugzilla – Full Text Bug Listing |
Summary: | univention-welcome-screen: cleanup script not executable | ||
---|---|---|---|
Product: | UCS | Reporter: | Erik Damrose <damrose> |
Component: | System setup | Assignee: | Alexander Kramer <kramer> |
Status: | CLOSED FIXED | QA Contact: | Erik Damrose <damrose> |
Severity: | normal | ||
Priority: | P5 | CC: | best, gohmann, walkenhorst |
Version: | UCS 4.0 | ||
Target Milestone: | UCS 4.0-3-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: |
Description
Erik Damrose
2015-08-10 18:57:53 CEST
As discussed with Erik and Florian I made 98_start_univention_welcome_screen executable instead of deleting it. There should be no problem with starting the service a second time during the init script. ucs4.0-3 r 63501 Package: univention-welcome-screen Version: 0.0.0-12.11.201509080956 r 63503 yaml file ucs4.1-0 r 63502 Package: univention-welcome-screen Version: 1.0.0-1.12.201509081000 (In reply to Alexander Kramer from comment #1) > There should be no problem with starting the service a second time during > the init script. Reopen: The init script seems to ignore other running welcome screen instances. After system setup a firefox with 2 tabs is running, both showing the welcome screen. This is a regression, because one can access the tabs at the top of the screen. If the init script is called from the console, a second stack of firefox + webserver is started, which overlays the current running one. The init script should check if a welcome screen is already running, and fail with a message that another instance is already running Why does this check doesn't work:? 44 » » if [ -e "/var/run/univention-welcome-screen.pid" ]; then 45 » » » pgrep -f firefox -F /var/run/univention-welcome-screen.pid > /dev/null 46 » » » if [ "0" != "$?" ]; then 47 » » » » log_action_end_msg 0 48 » » » » exit 0 49 » » » fi 50 » » fi Please make also sure that the script is not executed after the debian installer! Made sure that the welcome screen is only stared once during DI and System Setup. One also gets an msg if an instance is already running while calling the init script again. UCS 4.0-3 r 64614 Adapted debian rules and init script to avoid multiple running instances r 64628 Changed debian / rules --> dh_installinit defaults back to 99 Successful build Package: univention-welcome-screen Version: 0.0.0-14.14.201510201617 Branch: ucs_4.0-0 Scope: errata4.0-3 r 64631 yaml file UCS4.1-0 r 64632 merged changes Successful build Package: univention-welcome-screen Version: 1.0.0-2.15.201510201657 Branch: ucs_4.1-0 (In reply to Florian Best from comment #5) > Please make also sure that the script is not executed after the debian > installer! This still happens with the latest version in 4.1. To reproduce: Just boot via DVD run the debian installer run system setup click on the finish button. After that the welcome screen will be shown for a few seconds. Cleanup script starts welcome screen only if debian installer is not running UCS 4.0-3 / r 64721 Successful build Package: univention-welcome-screen Version: 0.0.0-15.17.201510221033 Branch: ucs_4.0-0 Scope: errata4.0-3 r 64748 yaml file UCS 4.1-0 / r 64751 Package: univention-welcome-screen Version: 1.0.0-4.18.201510221422 Branch: ucs_4.1-0 OK: improved running instance detection, u-w-s is not run twice OK: not starting if debian installer is running OK: I fixed the yaml file in r65083 OK: Merge to UCS 4.1 -> Verified |