Univention Bugzilla – Full Text Bug Listing |
Summary: | Case sensitive compare for "name attributes" | ||
---|---|---|---|
Product: | UCS | Reporter: | Janis Meybohm <meybohm> |
Component: | S4 Connector | Assignee: | Lukas Oyen <oyen> |
Status: | CLOSED FIXED | QA Contact: | Arvid Requate <requate> |
Severity: | normal | ||
Priority: | P5 | CC: | best, gohmann, grandjean, markus.daehlmann, requate, stoeckigt, thorp-hansen |
Version: | UCS 4.0 | Flags: | oyen:
Patch_Available+
|
Target Milestone: | UCS 4.2-2-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
See Also: | https://forge.univention.org/bugzilla/show_bug.cgi?id=44883 | ||
What kind of report is it?: | Bug Report | What type of bug is this?: | 4: Minor Usability: Impairs usability in secondary scenarios |
Who will be affected by this bug?: | 2: Will only affect a few installed domains | How will those affected feel about the bug?: | 3: A User would likely not purchase the product |
User Pain: | 0.137 | Enterprise Customer affected?: | Yes |
School Customer affected?: | Yes | ISV affected?: | |
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | 2015090221000181, 2016070721000129, 2017051721000264 | Bug group (optional): | |
Max CVSS v3 score: | |||
Attachments: |
39309-s4c-case-sensitive-compare-422.patch
normal_default.patch |
Description
Janis Meybohm
2015-09-04 10:09:57 CEST
happened again: Ticket#2016070721000129 Created attachment 9182 [details]
39309-s4c-case-sensitive-compare-422.patch
The S4C did in fact not strictly always use a case insensitive compare. The
attached patch sets `compare_lowercase()` as the default compare_function, if
none is given, in the `attribute` class. With this and the consistent use of the
`attribute.compare_function`, the S4C now defaults to case insensitive compare.
A new function `compare_normal()` is introduced that uses the normal Python
equality (==) and therefor performs case sensitive compare. This new compare
function is used for the following attributes: city, description, displayName,
firstname, lastname, organisation, street.
Other attributes seem to require case insensitive compare as their semantics
require case insensitive treatment (email, postal-code, paths, ..).
Pushed in 8e06721, YAML fcdcb93. *** Bug 34362 has been marked as a duplicate of this bug. *** Created attachment 9191 [details]
normal_default.patch
Se patch proposal above, I think we should keep compare_normal as default.
> Other attributes seem to require case insensitive compare as their semantics
> require case insensitive treatment (email, postal-code, paths, ..).
As discussed, the LDAP backend is case preserving, so we should also keep that as is.
(In reply to Arvid Requate from comment #5) > Created attachment 9191 [details] > normal_default.patch Applied in 1eca5d78, YAML (description update) 902bf00. Code review: Ok Jenkins: Ok |