Univention Bugzilla – Full Text Bug Listing |
Summary: | Add licence categories to the App Center | ||
---|---|---|---|
Product: | UCS | Reporter: | Nico Gulden <gulden> |
Component: | App Center | Assignee: | Dirk Wiesenthal <wiesenthal> |
Status: | CLOSED FIXED | QA Contact: | Florian Best <best> |
Severity: | enhancement | ||
Priority: | P5 | CC: | gohmann, jmm, walkenhorst, wiesenthal |
Version: | UCS 4.1 | ||
Target Milestone: | UCS 4.1-1-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: | |||
Bug Depends on: | |||
Bug Blocks: | 40872, 40941 |
Description
Nico Gulden
2016-01-14 10:45:50 CET
*** Bug 37617 has been marked as a duplicate of this bug. *** See http://appcenter-test.software-univention.de/meta-inf/license_types.ini ini file needs to specify License=free Also adds a "read" link to the LICENSE_AGREEMENT (would be bad manner to hide it if it is present), see Bug#37617. Always adds this link, not only when installed. If no License= and no LICENSE_AGREEMENT, shows: The App does not provide any information about the license. Please contact the App provider for further details. This will be the case for most of the Apps at the moment. We may want to add the License= attribute before this fix is released The Jenkins tests failed, for example: [2016-03-06 21:01:27.902381]Downloading "https://backup092.autotest092.local/meta-inf/4.1/index.json.gz"... [2016-03-06 21:01:27.915444]Downloading "https://backup092.autotest092.local/meta-inf/categories.ini"... [2016-03-06 21:01:27.931940]Downloading "https://backup092.autotest092.local/meta-inf/rating.ini"... [2016-03-06 21:01:27.948397]Downloading "https://backup092.autotest092.local/meta-inf/license_types.ini"... (2016-03-06 21:01:27.951763)Konnte https://backup092.autotest092.local/meta-inf/license_types.ini nicht herunterladen. Das deutet auf ein Problem auf dem App Center-Server hin. Bitte versuchen Sie es später noch einmal. [2016-03-06 21:01:28.013248]Cleanup after exception: <class 'dockertest.UCSTest_DockerApp_UpdateFailed'> http://jenkins.knut.univention.de:8080/job/UCS-4.1/job/UCS-4.1-1/job/Autotest%20MultiEnv/SambaVersion=s3,Systemrolle=backup/26/testReport/junit/80_docker/40_app_install_4_0-3/test/ If you click on "Read" to read the license agreement a pop up pops up. This pop up has a button "Contiune" - which is irritating. Please relabel into "Read license agreement" instead of just "Read". (In reply to Stefan Gohmann from comment #3) > The Jenkins tests failed, for example: > license_types.ini copied to appcenter (In reply to Florian Best from comment #4) > If you click on "Read" to read the license agreement a pop up pops up. This > pop up has a button "Contiune" - which is irritating. Changed to "Close" (In reply to Florian Best from comment #5) > Please relabel into "Read license agreement" instead of just "Read". Done Also, checking for empty license type. In this case nothing is shown (instead of 'The App does not provide ... '). This may be used for the first days until the App providers define their respective license type. See http://appcenter-test.software-univention.de/meta-inf/license_types.ini [empty]. License=emtpy will hide it unless a LICENSE_AGREEMENT is there to be read. (In reply to Dirk Wiesenthal from comment #6) > (In reply to Stefan Gohmann from comment #3) > > The Jenkins tests failed, for example: > > > > license_types.ini copied to appcenter OK, but let's see the test cases tomorrow. > (In reply to Florian Best from comment #4) > > If you click on "Read" to read the license agreement a pop up pops up. This > > pop up has a button "Contiune" - which is irritating. > > Changed to "Close" OK > (In reply to Florian Best from comment #5) > > Please relabel into "Read license agreement" instead of just "Read". > > Done OK > Also, checking for empty license type. In this case nothing is shown > (instead of 'The App does not provide ... '). This may be used for the first > days until the App providers define their respective license type. > > See http://appcenter-test.software-univention.de/meta-inf/license_types.ini > [empty]. > > License=emtpy will hide it unless a LICENSE_AGREEMENT is there to be read. REOPEN: This doesn't work. (Also If i fix your typo: License=emtpy / License=empty). (In reply to Dirk Wiesenthal from comment #6) > (In reply to Stefan Gohmann from comment #3) > > The Jenkins tests failed, for example: > > > > license_types.ini copied to appcenter If the file license_types.ini is mandatory, you need to adjust the test Appcenter class in ucs-test/tests/80_docker/dockertest.py. During the tests, a temporary App Center is created. I think it makes also sense to create tests for this issue. (In reply to Stefan Gohmann from comment #8) > If the file license_types.ini is mandatory, you need to adjust the test > Appcenter class in ucs-test/tests/80_docker/dockertest.py. During the tests, > a temporary App Center is created. > > I think it makes also sense to create tests for this issue. Fixed in ucs-test. I have created Bug#40855 for the test. (In reply to Florian Best from comment #7) > REOPEN: This doesn't work. (Also If i fix your typo: License=emtpy / > License=empty). Please re-check. It works for me. (In reply to Dirk Wiesenthal from comment #9) > (In reply to Stefan Gohmann from comment #8) > > If the file license_types.ini is mandatory, you need to adjust the test > > Appcenter class in ucs-test/tests/80_docker/dockertest.py. During the tests, > > a temporary App Center is created. > > > > I think it makes also sense to create tests for this issue. > > Fixed in ucs-test. I have created Bug#40855 for the test. OK > (In reply to Florian Best from comment #7) > > REOPEN: This doesn't work. (Also If i fix your typo: License=emtpy / > > License=empty). > > Please re-check. It works for me. OK YAML: OK (In reply to Nico Gulden from comment #0) > A new attribute should be added to the App Center meta data the provides a > combined information about the evaluation restrictions and the commercial > use. It should be shown in the App Center and the App Catalog. The attribute > should consist of the following options: > 1. Free commercial use > 2. Free commercial use and some functions are subject to costs > 3. Liable to Costs with free trial > 4. Liable to Costs without Free Trial Nico used the types in his communication with the ISVs. We have now other licenses types / texts in the license_types.ini file. Can we adjust the types in the license_types.ini file? (In reply to Stefan Gohmann from comment #11) > Can we adjust the > types in the license_types.ini file? Yes, this is always possible without having to change the appcenter package. The texts can be adjusted after the release of this update. Currently, the ini file looks like this: http://appcenter-test.software-univention.de/meta-inf/license_types.ini It will be updated as soon as possible. Same holds for ini files. *** Bug 32328 has been marked as a duplicate of this bug. *** |