Bug 40457

Summary:	Error handling in 98univention-samba4-dns.inst
Product:	UCS	Reporter:	Florian Best <best>
Component:	Samba4	Assignee:	Samba maintainers <samba-maintainers>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P5	CC:	requate, scheinig
Version:	UCS 5.0
Target Milestone:	---
Hardware:	Other
OS:	Linux
See Also:	https://forge.univention.org/bugzilla/show_bug.cgi?id=42985 https://forge.univention.org/bugzilla/show_bug.cgi?id=43280 https://forge.univention.org/bugzilla/show_bug.cgi?id=44227
What kind of report is it?:	Bug Report	What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	2: Will only affect a few installed domains	How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.069	Enterprise Customer affected?:
School Customer affected?:	Yes	ISV affected?:
Waiting Support:		Flags outvoted (downgraded) after PO Review:
Ticket number:	2017072421000327	Bug group (optional):	Error handling
Max CVSS v3 score:
Attachments:	patch

Description Florian Best

2016-01-19 09:35:48 CET

I see the following messages in the join.log:

cannot reset server in localhost-only mode
syntax error
cannot reset server in localhost-only mode
syntax error
Failed update of 2 entries

The joinscript nevertheless exits with 0.
Here is the full log.

RUNNING 98univention-samba4-dns.inst
2016-01-18 18:36:18.931560843+01:00 (in joinscript_init)
Waiting for RID Pool replication: done.
Not updating samba4/sysvol/sync/cron
Adding CNAME record "3ff3015c-1999-4048-be9d-91ec738b5c4c._msdcs ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "ldap tcp 0 100 389 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Does not exist
Adding SRV record "ldap._tcp.dc msdcs 0 100 389 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "ldap._tcp.aa7a9533-db0c-426c-9ca0-78e7513891de.domains msdcs 0 100 389 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
No record found
Adding SRV record "kerberos tcp 0 100 88 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "kerberos udp 0 100 88 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "kerberos._tcp.dc msdcs 0 100 88 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "kpasswd tcp 0 100 464 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "kpasswd udp 0 100 464 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "ldap._tcp.Default-First-Site-Name sites 0 100 389 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "ldap._tcp.Default-First-Site-Name._sites.dc msdcs 0 100 389 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "kerberos._tcp.Default-First-Site-Name sites 0 100 88 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "kerberos._tcp.Default-First-Site-Name._sites.dc msdcs 0 100 88 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding TXT record "_kerberos UNIVENTION-PT41.INTRANET" to zone univention-pt41.intranet...
done
Adding A record "gc._msdcs 192.168.0.113" to zone univention-pt41.intranet...
done
Adding SRV record "gc tcp 0 100 3268 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "ldap._tcp.gc msdcs 0 100 3268 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "gc._tcp.Default-First-Site-Name sites 0 100 3268 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "ldap._tcp.Default-First-Site-Name._sites.gc msdcs 0 100 3268 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
Adding SRV record "ldap._tcp.pdc msdcs 0 100 389 ucs-1843.univention-pt41.intranet." to zone univention-pt41.intranet...
done
cannot reset server in localhost-only mode
syntax error
cannot reset server in localhost-only mode
syntax error
Failed update of 2 entries
2016-01-18 18:36:35.648963666+01:00 (in joinscript_save_current_version)
EXITCODE=0

Comment 1 Arvid Requate

2016-01-19 17:37:46 CET

I guess we need to fix 4.1-0-0-ucs/2:4.3.3-1-errata4.1-0/95_dnsupdate.patch for this. This patch adds the option --local to the samba_dnsupdate script, which causes nsupdate to be called with the option "-l".

As far as I can see the samba_dnupdate script must not pass a "server " line to nsupdate in that case.

Comment 2 Florian Best

2017-01-03 15:15:16 CET

This bug should also change that the joinscript fails with an error code != 0 in any case where something fails.

Comment 3 Florian Best

2017-08-03 16:13:10 CEST

Created attachment 9089 [details]
patch

Patch attaches "|| die" to relevant joinscript calls.

Comment 4 Arvid Requate

2017-08-03 16:17:48 CEST

We need to fix Comment 1 too, otherwise support will be unhappy.

Comment 5 Florian Best

2017-08-03 16:19:49 CEST

(In reply to Arvid Requate from comment #4)
> We need to fix Comment 1 too, otherwise support will be unhappy.
Yes, the new file is:
svn/patches/samba/4.2-0-0-ucs/2:4.6.1-1-errata4.2-1/95_dnsupdate.quilt