Univention Bugzilla – Full Text Bug Listing |
Summary: | It should be possible to add links and modules as a shallow copy to an overview category | ||
---|---|---|---|
Product: | UCS | Reporter: | Alexander Kramer <kramer> |
Component: | UMC (Generic) | Assignee: | Alexander Kramer <kramer> |
Status: | CLOSED FIXED | QA Contact: | Florian Best <best> |
Severity: | normal | ||
Priority: | P5 | CC: | gohmann, klaeser, walkenhorst |
Version: | UCS 4.1 | ||
Target Milestone: | UCS 4.1-0-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: | |||
Bug Depends on: | |||
Bug Blocks: | 38957 | ||
Attachments: |
example of an xml file
patch code cleanup patch for DTD xml file for qa |
Description
Alexander Kramer
2016-01-28 14:16:24 CET
With this changes it is possible to: - add more than one module to a xml file - the modules / flavors will be merged to make show copies possible - add link elements Questions: Should it be possible to control links by acls? r67044 univention-management-console-frontend (5.0.63-14) * Bug #40528: Display links and shallow copies of modules in categories Successful build 5.0.63-14.1201.201601281429 r67045 yaml file ---- r67046 univention-management-console (8.0.28-6) * Bug #40528: Display links and shallow copies of modules in categories Successful build 8.0.28-6.909.201601281440 r67047 yaml file Created attachment 7434 [details]
example of an xml file
Maybe helpful for QA
TODO dtd file: remove possibility of url element in module adapt comment of link element and remove version and notifier module.py if '__link' in mod.id: --> if mod.id.startswith('__link') Created attachment 7435 [details]
patch code cleanup
As discussed I adapted the files. FYI: A link is now defined by having an url and not by a leading '__link' inside the id. r67112 univention-management-console-frontend (5.0.63-16) * Bug #40528: A link is now defined by having a url Successful build Package: univention-management-console-frontend Version: 5.0.63-16.1203.201602020908 r67113 yaml file r67114 univention-management-console (8.0.28-7) * Bug #40528: Code clean up and adapted dtd file Successful build Package: univention-management-console Version: 8.0.28-7.910.201602020917 r67115 yaml file I reverted the changes to the UMC frontend in order to be able to release staging errata for the package: univention-management-console-frontend (5.0.63-17): r67159 | Bug #40528: temporarily reverted last changes r67158 | Revert "* Bug #40528: Display links and shallow copies of modules in categories" r67157 | Revert "* Bug #40528: A link is now defined by having a url" The changes for the package univention-management-console have been left untouched as there are no other errata pending for it. UMC frontend package is building. Package built + adjusted the YAML file: univention-management-console-frontend.yaml: r67160 | Bug #40528: removed entry from YAML file + updated package version Created attachment 7451 [details]
patch for DTD
r67209 univention-management-console-frontend (5.0.63-18) * Bug #40528: Added the changes again Successful build Package: univention-management-console-frontend Version: 5.0.63-18.1205.201602050848 r67210 yaml file (In reply to Florian Best from comment #9) > Created attachment 7451 [details] > patch for DTD r67216 univention-management-console (8.0.28-8) * Bug #40528: Applied patch for dtd file Successful build Package: univention-management-console Version: 8.0.28-8.911.201602051217 yaml file 67218 1. Please ignore <link> elements without <url>-tag - as they are invalid and wouldn't do anything on the overview. 2. Please make the URI translatable. 3. The UMC frontend does not load / is empty if there are modules with multiple _foo_ categories. I guess the following code causes this: + if (item.is_shallow_copy && item.categories.length > 1) { + item.category_for_color = array.filter(item.categories, lang.hitch(this, function(cat) { + return !this._is_shallow_copy(cat); + }))[0]; + } → element [0] doesn't exists. r67283 univention-management-console (8.0.29-1) * Bug #40528: ignore links without url element make uri translateable r67285 adapted debian/changelog Successful build Package: univention-management-console Version: 8.0.28-9.913.201602100730 r67286 yaml file ---- r67287 univention-management-console-frontend (5.0.63-19) * Bug #40528: Allow multiple categories like _favorites_ Successful build Package: univention-management-console-frontend Version: 5.0.63-19.1206.201602100743 r67288 yaml file r67294 univention-management-console (8.0.28-10) * Bug #40528: replaced translationId with id Successful build Package: univention-management-console Version: 8.0.28-10.914.201602100840 r67295 yaml file Created attachment 7462 [details]
xml file for qa
this xml file covers 4 scenarios:
(1) add a module as an shallow copy
(2) add a link also to another category / module
(3) add a link with multiple underscored categories like _favorites_
(4) do not add a invalid link without an url element
OK: FF | IE | Chromium OK: <link> OK: DTD OK: <module>/<flavor>-category-merging OK: translations OK: YAML Permissions → Bug #40626 It is also possible to create a pop up with this: <link id="popup" priority="150" version="1.0"> <name>Pop up</name> <description></description> <url>javascript:require('umc/dialog').alert('Hello world!');</url> <categories> <category name="domain"/> </categories> </link> Together with Florian (QA) we added the following changes to make link elements translatable: r67309 univention-management-console (8.0.28-11) * Bug #40528: adjust dh_umc.py to also collect translations of <link> elements Successful build Package: univention-management-console Version: 8.0.28-11.915.201602101423 r67310 |