Univention Bugzilla – Full Text Bug Listing |
Summary: | Fallback for an empty favorites category is always the second element in the categories array | ||
---|---|---|---|
Product: | UCS | Reporter: | Jürn Brodersen <brodersen> |
Component: | UMC (Generic) | Assignee: | Jürn Brodersen <brodersen> |
Status: | CLOSED FIXED | QA Contact: | Alexander Kläser <klaeser> |
Severity: | normal | ||
Priority: | P5 | CC: | best, klaeser, walkenhorst |
Version: | UCS 4.1 | ||
Target Milestone: | UCS 4.1-1-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: | |||
Bug Depends on: | |||
Bug Blocks: | 38957 | ||
Attachments: |
Proposed patch
Proposed patch v2 |
Description
Jürn Brodersen
2016-03-18 09:51:35 CET
Created attachment 7544 [details]
Proposed patch v2
It would also be nice to select the category with the highest priority if no category is specified instead of selecting the favorites.
You can use array.filter() from dojo - this is cross browser compatible; object.id dot notation is easier to read instead of ['id'] - jshint complains otherwise. Add missing semicolon. array.filter(this.getCategories(), function(category) { return category.id != '_favorites_'; })[0] UCS4.1-1: r68252: * make sure the fallback for an empty favorites category isn't the favorites category r68254: YAML Package: univention-management-console-frontend Version: 5.0.63-31.1221.201603231043 Changes: OK, they work fine :) ! YAML file: OK, minor adjustment [r68423] VERIFIED |