Univention Bugzilla – Full Text Bug Listing |
Summary: | remove dead code from custom-attributes | ||
---|---|---|---|
Product: | UCS | Reporter: | Florian Best <best> |
Component: | UDM (Generic) | Assignee: | Florian Best <best> |
Status: | CLOSED FIXED | QA Contact: | Philipp Hahn <hahn> |
Severity: | normal | ||
Priority: | P5 | CC: | gohmann, hahn |
Version: | UCS 4.1 | ||
Target Milestone: | UCS 4.1-2-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | Bug Report | What type of bug is this?: | 3: Simply Wrong: The implementation doesn't match the docu |
Who will be affected by this bug?: | 2: Will only affect a few installed domains | How will those affected feel about the bug?: | 2: A Pain – users won’t like this once they notice it |
User Pain: | 0.069 | Enterprise Customer affected?: | |
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | API change, Cleanup | |
Max CVSS v3 score: | |||
Bug Depends on: | |||
Bug Blocks: | 41553, 41554, 41556 |
Description
Florian Best
2016-05-12 10:04:29 CEST
Removed that code during working on Bug #25240. It costs a lot of time to always read broken code. univention-directory-manager-modules (11.0.2-30): r69513 | Bug #41266: remove dead custom-attributes code univention-directory-manager-modules.yaml: r69515 | YAML Bug #41266 Bug #25240 *** Bug 31769 has been marked as a duplicate of this bug. *** r69538 | Bug #41266: removed some more unused custom-attributes code (In reply to Florian Best from comment #1) > Removed that code during working on Bug #25240. It costs a lot of time to > always read broken code. > > univention-directory-manager-modules (11.0.2-30): > r69513 | Bug #41266: remove dead custom-attributes code REOPEN: Please remove the code in _ldap_modlist() completely instead of out-commenting it. > univention-directory-manager-modules.yaml: > r69515 | YAML Bug #41266 Bug #25240 OK (In reply to Florian Best from comment #3) > r69538 | Bug #41266: removed some more unused custom-attributes code OK (In reply to Florian Best from comment #2) > *** Bug 31769 has been marked as a duplicate of this bug. *** REOPEN: More CA related code to be removed in etc/bash_completion.d/univention-directory-manager test/univention-admin-test modules/univention/admin/__init__.py (In reply to Philipp Hahn from comment #4) > REOPEN: Please remove the code in _ldap_modlist() completely instead of > out-commenting it. That code contains information which are still valid and should be reimplemented some day. > REOPEN: More CA related code to be removed in > etc/bash_completion.d/univention-directory-manager Yes, fixed. > test/univention-admin-test That scripts seems broken, the LDAP server doesn't start after applying the schema in there. Nevertheless is converted custom-attributes → extended attributes in there. > modules/univention/admin/__init__.py I don't see Code in there which still refers to custom attributes (only two comments which have been adjusted). univention-directory-manager-modules (11.0.3-2): r69968 | Bug #41266: remove more custom attribute related code (In reply to Florian Best from comment #5) > (In reply to Philipp Hahn from comment #4) > > REOPEN: Please remove the code in _ldap_modlist() completely instead of > > out-commenting it. > That code contains information which are still valid and should be > reimplemented some day. Such commented out code tends to get stale very quickly because nobody will touch it or keep it up-to-date. We have source code control for archaeologists, so please remove it. (In reply to Florian Best from comment #5) > (In reply to Philipp Hahn from comment #4) > > REOPEN: Please remove the code in _ldap_modlist() completely instead of > > out-commenting it. > That code contains information which are still valid and should be > reimplemented some day. Such commented out code tends to get stale very quickly because nobody will touch it or keep it up-to-date. The source code is no TODO-list or issue tracking system; please file a new bug to re-implement it if necessary; then management can decide on the importance. We also have source code control if someone wants to lookup old code, so please remove it. Your wish is my command. univention-directory-manager-modules (11.0.3-3): r70014 | Bug #41266: remove commented out code OK: r69968 r70014 TODO: Bug #41553, Bug #41554, Bug #41556 FIXED: errata-announce -V univention-directory-manager-modules.yaml r70158 | Bug #41266 udm-modules: YAML v++ OK: EA & EO still work |