Bug 41695

Summary: saml/serviceprovider defines multiple properties with identifies=True
Product: UCS Reporter: Florian Best <best>
Component: SAMLAssignee: Johannes Keiser <keiser>
Status: CLOSED FIXED QA Contact: Florian Best <best>
Severity: normal    
Priority: P5 CC: gohmann
Version: UCS 4.1Flags: best: Patch_Available+
Target Milestone: UCS 4.2-1-errata   
Hardware: Other   
OS: Linux   
What kind of report is it?: Development Internal What type of bug is this?: ---
Who will be affected by this bug?: --- How will those affected feel about the bug?: ---
User Pain: Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: Bug group (optional):
Max CVSS v3 score:
Attachments: patch

Description Florian Best univentionstaff 2016-06-29 01:02:23 CEST
Created attachment 7774 [details]
patch

saml/serviceprovider defines the following properties as identifies=True - while it shouldn't: ['singleLogoutService', 'attributesNameFormat', 'simplesamlNameIDAttribute', 'serviceProviderOrganizationName', 'LDAPattributes', 'privacypolicyURL', 'AssertionConsumerService', 'NameIDFormat', 'serviceproviderdescription']
Comment 1 Johannes Keiser univentionstaff 2017-07-03 14:25:37 CEST
(In reply to Florian Best from comment #0)
> Created attachment 7774 [details]
> patch
> 
> saml/serviceprovider defines the following properties as identifies=True -
> while it shouldn't: ['singleLogoutService', 'attributesNameFormat',
> 'simplesamlNameIDAttribute', 'serviceProviderOrganizationName',
> 'LDAPattributes', 'privacypolicyURL', 'AssertionConsumerService',
> 'NameIDFormat', 'serviceproviderdescription']

Applied rebased patch:

r 80777
univention-saml (4.0.14-5) 
* Bug #41695: Applied patch from Florian Best - Fix definition of multiple
identifies=True properties

YAML: r 80779
Comment 2 Johannes Keiser univentionstaff 2017-07-03 14:30:44 CEST
r 80780
univention-saml (4.0.14-6) 
* Bug #41695: Applied additional patch - cleanup
Comment 3 Florian Best univentionstaff 2017-07-03 14:42:58 CEST
OK: removed the identifies flags from properties that aren't identifying the object
OK: removal of obsolete code, which works automatically due to the above change
OK: YAML (adjusted in r80781)
Comment 4 Janek Walkenhorst univentionstaff 2017-07-05 13:06:28 CEST
<http://errata.software-univention.de/ucs/4.2/85.html>