Univention Bugzilla – Full Text Bug Listing |
Summary: | Create snapshot via right click context menu | ||
---|---|---|---|
Product: | UCS | Reporter: | Florian Best <best> |
Component: | UMC - Virtual machines (UVMM) | Assignee: | Jannik Ahlers <ahlers> |
Status: | CLOSED FIXED | QA Contact: | Philipp Hahn <hahn> |
Severity: | normal | ||
Priority: | P5 | CC: | ahlers, damrose, keiser, klaeser, requate |
Version: | UCS 4.3 | Flags: | best:
Patch_Available-
|
Target Milestone: | UCS 4.3-1-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
See Also: | https://forge.univention.org/bugzilla/show_bug.cgi?id=33005 | ||
What kind of report is it?: | Feature Request | What type of bug is this?: | 2: Improvement: Would be a product improvement |
Who will be affected by this bug?: | 3: Will affect average number of installed domains | How will those affected feel about the bug?: | 1: Nuisance – not a big deal but noticeable |
User Pain: | 0.034 | Enterprise Customer affected?: | |
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | Usability | |
Max CVSS v3 score: | |||
Attachments: | patch |
Description
Florian Best
2016-07-12 09:02:04 CEST
Created attachment 9048 [details]
patch
I think it would be better to either: * require('uvmm/SnapshotGrid') manually and call the create function there (* move the function out of the detail page into a own function?) Missing is also a canExecute function for the grid action which must at least check if the server/poll is available (item.node_available). Added a patch under branch jahlers/41772-uvmm-snapshot in which i moved the function out of the detailpage. Please check the proposed patch and reopen with a verdict. OK: Snapshot from context menu OK: Snapshot from dialog REOPEN: 1. Please merge the 3 patches as they are not 3 distinct changes 2. Please rename the menu entry to "+Create +snapshot" (don't make Bug #31858 worse) 3. I pushed two more required changes: [jahlers/41772-uvmm-snapshot] a45d5b5b6b Bug #41772: Do not create empty snapshots [jahlers/41772-uvmm-snapshot] 8ec86caabe Bug #41772: Abort early if failed pre-condition Otherwise good work. I applied the changes you suggested in your comments. I will still not merge the branch as there is no target milestone set yet. (In reply to Jannik Ahlers from comment #6) > I applied the changes you suggested in your comments. OK: <https://git.knut.univention.de/univention/ucs/commits/jahlers/41772-uvmm-snapshot> TODO: Please check that "Create snapshot" is translated. > I will still not merge the branch as there is no target milestone set yet. errata4.3-1 I adapted the translations to Bug #31858. Successful build Package: univention-virtual-machine-manager-daemon Version: 7.0.0-8A~4.3.0.201806281447 Branch: ucs_4.3-0 Scope: errata4.3-1 OK: apt install {univention-virtual-machine-manager-daemon,python-univention-virtual-machine-manager,univention-management-console-module-uvmm}=7.0.0-8A~4.3.0.201806281447 OK: errata-announce -V --only univention-virtual-machine-manager-daemon.yaml FIXED: univention-virtual-machine-manager-daemon.yaml [4.3-1] 4e84ac8970 Bug #41772: Fix uvmm.YAML FAIL: I get the following "error" in the JS-console of Chromium if I start creating a Snapshot but then press "Cancel" when being asked for the snapshot name: dojo.js.uncompressed.js:6520 undefined " ---------------------------------------- rejected at a (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:84:505) at d (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:84:271) at l (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:84:24) at b.h.reject (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:86:305) at Object.callback (http://xen1.knut.univention.de/univention/management/modules/uvmm/snapshot.js:119:16) at Object.<anonymous> (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:42:327) at Object.q [as onClick] (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:81:403) at Object._onClick (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:330:422) at HTMLInputElement.<anonymous> (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:42:327) at Object.__onClick (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:330:306) ---------------------------------------- Error at h.extend.then.then.c.then (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:86:415) at Object.<anonymous> (http://xen1.knut.univention.de/univention/management/modules/uvmm.js:1519:50) at http://xen1.knut.univention.de/univention/js/dojo/dojo.js:42:380 at d (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:84:98) at l (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:84:24) at b.resolve (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:86:97) at a (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:84:479) at d (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:84:238) at l (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:84:24) at b.resolve (http://xen1.knut.univention.de/univention/js/dojo/dojo.js:86:97)" univention-virtual-machine-manager-daemon (7.0.0-10) edeaafd7da4f | Bug #41772: Fix javascript traceback Successful build Package: univention-virtual-machine-manager-daemon Version: 7.0.0-10A~4.3.0.201807031737 Branch: ucs_4.3-0 Scope: errata4.3-1 The deferred object had to be canceled, not rejected. I fixed this in a few other instances as well (e.g. when the domain is suspended). (In reply to Jannik Ahlers from comment #10) > univention-virtual-machine-manager-daemon (7.0.0-10) > edeaafd7da4f | Bug #41772: Fix javascript traceback OK > Package: univention-virtual-machine-manager-daemon > Version: 7.0.0-10A~4.3.0.201807031737 OK: apt install {univention-virtual-machine-manager-daemon,python-univention-virtual-machine-manager,univention-management-console-module-uvmm}=7.0.0-10A~4.3.0.201807031737 > The deferred object had to be canceled, not rejected. I fixed this in a few > other instances as well (e.g. when the domain is suspended). OK: errata-announce -V --only univention-virtual-machine-manager-daemon.yaml OK: 95714a19ecd549de2ec54951cf7580d519b8bd1c OK: Create from menu OK: Create from dialog OK: Cancel create OK: Delete from dialog --- mirror/ftp/4.3/unmaintained/4.3-0/source/univention-virtual-machine-manager-daemon_7.0.0-6A~4.3.0.201803111236.dsc +++ apt/ucs_4.3-0-errata4.3-1/source/univention-virtual-machine-manager-daemon_7.0.0-10A~4.3.0.201807031737.dsc @@ -1,6 +1,24 @@ -7.0.0-6A~4.3.0.201803111236 [Sun, 11 Mar 2018 12:36:31 +0100] Univention builddaemon <buildd@univention.de>: +7.0.0-10A~4.3.0.201807031737 [Tue, 03 Jul 2018 17:37:49 +0200] Univention builddaemon <buildd@univention.de>: * UCS auto build. No patches were applied to the original source package + +7.0.0-10 [Tue, 03 Jul 2018 17:33:48 +0200] Jannik Ahlers <ahlers@univention.de>: + + * Bug #41772: fix javascript traceback + +7.0.0-9 [Fri, 29 Jun 2018 11:59:37 +0200] Erik Damrose <damrose@univention.de>: + + * Bug #47268: Make CPU-Usage column visibility configurable + +7.0.0-8 [Tue, 22 May 2018 12:01:42 +0200] Jannik Ahlers <ahlers@univention.de>: + + * Bug #41772: relocated functionality to add snapshots to own javascript + file to enable snapshots being made in right click context menu in vm list + grid + +7.0.0-7 [Thu, 14 Jun 2018 16:21:25 +0200] Johannes Keiser <keiser@univention.de>: + + * Bug #47182: Sort valid hosts for migrate option 7.0.0-6 [Sun, 11 Mar 2018 12:34:07 +0100] Stefan Gohmann <gohmann@univention.de>: <http://10.200.17.11/4.3-1/#8750627010527936956> |