Bug 42493
| Summary: | univention-skel does not check if symlink already exists | ||
|---|---|---|---|
| Product: | UCS | Reporter: | Jens Thorp-Hansen <thorp-hansen> |
| Component: | univention-base-files | Assignee: | Felix Botner <botner> |
| Status: | CLOSED FIXED | QA Contact: | Janek Walkenhorst <walkenhorst> |
| Severity: | normal | ||
| Priority: | P5 | CC: | gohmann, markus.daehlmann |
| Version: | UCS 4.1 | ||
| Target Milestone: | UCS 4.1-3-errata | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| What kind of report is it?: | Bug Report | What type of bug is this?: | 3: Simply Wrong: The implementation doesn't match the docu |
| Who will be affected by this bug?: | 1: Will affect a very few installed domains | How will those affected feel about the bug?: | 2: A Pain – users won’t like this once they notice it |
| User Pain: | 0.034 | Enterprise Customer affected?: | Yes |
| School Customer affected?: | Yes | ISV affected?: | |
| Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
| Ticket number: | 2016092321000532 | Bug group (optional): | |
| Max CVSS v3 score: | |||
Ticket#2016092321000532 will gain severity for the customer if not fixed in the intermediate-term. fixed in univention-skel in errata4.1-3 univention-skel.yaml merged to 4.2-0 Tests: OK Advisory: OK Code review: OK Merge: OK |
steps to reproduce: root@dc:~# ln -s /doesnotexist /etc/univention/skel/faultylink root@dc:~# univention-skel /etc/univention/skel create_link /root/faultylink root@dc:~# univention-skel /etc/univention/skel create_link /root/faultylink Traceback (most recent call last): File "/usr/bin/univention-skel", line 200, in <module> os.path.walk(userconfig_templates, install_files, (hstamps, istamps)) File "/usr/lib/python2.7/posixpath.py", line 238, in walk func(arg, top, names) File "/usr/bin/univention-skel", line 135, in install_files os.symlink(os.readlink(ifile), hfile) OSError: [Errno 17] File exists