Univention Bugzilla – Full Text Bug Listing |
Summary: | UCR overwritten syntax classes cannot have choices | ||
---|---|---|---|
Product: | UCS | Reporter: | Florian Best <best> |
Component: | UMC - Domain management (Generic) | Assignee: | Florian Best <best> |
Status: | CLOSED FIXED | QA Contact: | Dirk Wiesenthal <wiesenthal> |
Severity: | normal | ||
Priority: | P5 | CC: | birkefeld, schwardt |
Version: | UCS 4.1 | Flags: | best:
Patch_Available+
|
Target Milestone: | UCS 4.1-4-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | Bug Report | What type of bug is this?: | 5: Major Usability: Impairs usability in key scenarios |
Who will be affected by this bug?: | 2: Will only affect a few installed domains | How will those affected feel about the bug?: | 2: A Pain – users won’t like this once they notice it |
User Pain: | 0.114 | Enterprise Customer affected?: | Yes |
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: | |||
Attachments: |
patch
Script to prove that the changes doesn't introduce any regression |
Description
Florian Best
2016-12-01 17:50:29 CET
Created attachment 8342 [details]
patch
from univention.management.console.modules.udm import *
set_bind_function(lambda lo: lo.bind('uid=Administrator,cn=users,dc=school,dc=local', 'univention'))
user = UDM_Module('users/user')
props = user.properties
[x for x in props if x['id'] == 'mailHomeServer']
The problem was that prior setting the value the syntax was the class MailHomeServer but when setting it via UCR it is an instance of the class MailHomeServer which leads to these problems as there are partly no isinstance-checks. Created attachment 8343 [details] Script to prove that the changes doesn't introduce any regression Attached is a script to prove that the changes don't affect other syntax classes/properties. It compares the properties-result of all properties of all UDM modules with the applied patch and the not-applied patch. # wget -O 43094.patch 'https://forge.univention.org/bugzilla/attachment.cgi?id=8342' # python bug_43094_proove_no_regressions.py > prior.json # patch -i "$PWD/43094.patch" -d /usr/share/pyshared/univention/management/console/modules/udm/ -p6 # python bug_43094_proove_no_regressions.py > after.json # md5sum prior.json after.json → the hashes are equal univention-management-console-module-udm (6.0.11-35): r75645 | Bug #43094: allow syntax overriden via UCR to have choices univention-management-console-module-udm.yaml: r75646 | YAML Bug #43094 univention-management-console-module-udm (7.0.3-2): r75647 | Bug #43094: allow syntax overriden via UCR to have choices *** Bug 34070 has been marked as a duplicate of this bug. *** Changeset: OK YAML: OK Merge: OK |