Bug 43176

Summary:	rejoin failed due to unsupported samba-tool option --keep-existing
Product:	UCS	Reporter:	Felix Botner <botner>
Component:	Samba4	Assignee:	Arvid Requate <requate>
Status:	CLOSED FIXED	QA Contact:	Felix Botner <botner>
Severity:	normal
Priority:	P5	CC:	gohmann, requate
Version:	UCS 4.1
Target Milestone:	UCS 4.1-4-errata
Hardware:	Other
OS:	Linux
See Also:	https://forge.univention.org/bugzilla/show_bug.cgi?id=36090
What kind of report is it?:	Bug Report	What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	1: Will affect a very few installed domains	How will those affected feel about the bug?:	5: Blocking further progress on the daily work
User Pain:	0.086	Enterprise Customer affected?:
School Customer affected?:		ISV affected?:
Waiting Support:		Flags outvoted (downgraded) after PO Review:
Ticket number:		Bug group (optional):
Max CVSS v3 score:

Description Felix Botner

2016-12-14 10:42:44 CET

ucs4.1-4 master + s4 and ucs 4.1-4 backup +s4, backup joined,

univention-join on the backup fails

Configure 96univention-samba4.inst                         failed


**************************************************************************
* Join failed!                                                           *
* Contact your system administrator                                      *
**************************************************************************
* Message:  FAILED: 96univention-samba4.inst
**************************************************************************


join.log:

Stopping ldap server(s): slapd ...done.
Starting ldap server(s): slapd ...done.
Object removed: relativeDomainName=0fe6f5e1-0e85-4c5b-8fc1-bcfb47f7e7ea._msdcs,zoneName=four.test,cn=dns,dc=four,dc=test
extract_rIDNextRID: Saving rid pool
Not updating windows/wins-support
Join against S4 Connector server: master
Forest           : four.test
Domain           : four.test
Netbios domain   : FOUR
DC name          : master.four.test
DC netbios name  : MASTER
Server site      : Default-First-Site-Name
Client site      : Default-First-Site-Name
Usage: samba-tool domain join <dnsdomain> [DC|RODC|MEMBER|SUBDOMAIN] [options]

samba-tool domain join: error: no such option: --keep-existing
Failed to join against the S4 Connector server master.
Forest           : four.test
Domain           : four.test
Netbios domain   : FOUR
DC name          : master.four.test
DC netbios name  : MASTER
Server site      : Default-First-Site-Name
Client site      : Default-First-Site-Name
Usage: samba-tool domain join <dnsdomain> [DC|RODC|MEMBER|SUBDOMAIN] [options]

-> grep -r "keep-existing" *
96univention-samba4.inst:                                       samba_join_options=( --keep-existing )
96univention-samba4.inst:                       samba_join_options=( --keep-existing )
96univention-samba4.inst:               samba_domain_join --keep-existing

seems that 92_bug27027_keep_existing_option_for_domain_join_dc.patch.DISABLED is missing?

Comment 1 Stefan Gohmann

2016-12-14 11:18:20 CET

Did you use the latest unreleased errata updates?

Comment 2 Arvid Requate

2016-12-14 11:52:06 CET

Disabled since UCS 4.1-4

4.1-0-0-ucs/2:4.5.1-1-ucs4.1-4/92_bug27027_keep_existing_option_for_domain_join_dc.patch.DISABLED

I'll check if we can remove in from univention-samba4 now or if we need to merge the patch.

Comment 3 Arvid Requate

2016-12-14 21:15:46 CET

I've updated and re-activated the patch, now re-join works again.

Advisory: samba.yaml

The version number is not yet up to date due to Bug #43144.

Comment 4 Felix Botner

2016-12-16 17:29:55 CET

OK - rejoin, sid not changes, 
     join.log:
     Joined domain FOUR (SID S-1-5-21-854837004-1585209202-1099490383) as a DC
     keeping existing samaccount: CN=BACKUP,OU=Domain Controllers,DC=four,DC=test

OK - yaml

Comment 5 Arvid Requate

2016-12-19 12:46:12 CET

<http://errata.software-univention.de/ucs/4.1/360.html>