Bug 43273

Summary: local variable 'windomain' referenced before assignment
Product: UCS Reporter: Florian Best <best>
Component: UMC - Setup wizardAssignee: Florian Best <best>
Status: CLOSED FIXED QA Contact: Richard Ulmer <ulmer>
Severity: normal    
Priority: P5    
Version: UCS 4.1   
Target Milestone: UCS 4.2-0-errata   
Hardware: Other   
OS: Linux   
See Also: https://forge.univention.org/bugzilla/show_bug.cgi?id=44394
What kind of report is it?: Bug Report What type of bug is this?: 6: Setup Problem: Issue for the setup process
Who will be affected by this bug?: 1: Will affect a very few installed domains How will those affected feel about the bug?: 3: A User would likely not purchase the product
User Pain: 0.103 Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: 2016122921000239, 2017050721000096 Bug group (optional): External feedback
Max CVSS v3 score:
Attachments: patch

Description Florian Best univentionstaff 2017-01-02 17:50:04 CET
Version: 4.1-4 errata366 (Vahr)

Traceback(d41d8cd98f00b204e9800998ecf8427e):
Ein unerwarteter Fehler trat während des Einrichtungsprozesses auf: local variable 'windomain' referenced before assignment
Comment 1 Florian Best univentionstaff 2017-01-02 17:51:06 CET
Created attachment 8329 [details]
patch

Function was added in svn r52011.
Happens if the entered domainname doesn't contain a dot.
Comment 2 Florian Best univentionstaff 2017-05-10 16:10:40 CEST
Reported again, 4.1-4 errata324 (Vahr)
Comment 3 Florian Best univentionstaff 2017-05-29 17:24:41 CEST
Can be reproduced in a python shell:
# python
>>> from univention.management.console.modules.setup.util import domain2windowdomain
>>> domain2windowdomain('foo')

univention-system-setup (10.0.10-19):
r79939 | Bug #43273: don't crash if given domainname contains no dot

univention-system-setup.yaml:
r79941 | YAML Bug #44035 Bug #44394 Bug #43273
Comment 4 Richard Ulmer univentionstaff 2017-05-30 09:38:23 CEST
The change looks reasonable and the function works with inputs without '.'s now. -> Verified.
Comment 5 Janek Walkenhorst univentionstaff 2017-06-19 15:04:48 CEST
<http://errata.software-univention.de/ucs/4.2/50.html>