Univention Bugzilla – Full Text Bug Listing |
Summary: | restore_data_before_setup restores slightly broken UCR variables | ||
---|---|---|---|
Product: | UCS | Reporter: | Dirk Wiesenthal <wiesenthal> |
Component: | App Center | Assignee: | Dirk Wiesenthal <wiesenthal> |
Status: | CLOSED FIXED | QA Contact: | Felix Botner <botner> |
Severity: | normal | ||
Priority: | P5 | CC: | best |
Version: | UCS 4.1 | ||
Target Milestone: | UCS 4.1-4-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | Bug Report | What type of bug is this?: | 5: Major Usability: Impairs usability in key scenarios |
Who will be affected by this bug?: | 1: Will affect a very few installed domains | How will those affected feel about the bug?: | 3: A User would likely not purchase the product |
User Pain: | 0.086 | Enterprise Customer affected?: | |
School Customer affected?: | ISV affected?: | Yes | |
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: |
Description
Dirk Wiesenthal
2017-01-10 23:24:36 CET
(In reply to Dirk Wiesenthal from comment #0) > When fixing this, I feel we should extend the BLACKLIST of UCRVs not copied > by those set by the App Center itself (ldap/*, > repository/app_center_server', ...). This may not be a good idea as we then need to keep those lists in sync. I don't understand the problem, can you explain again? The problem is that when exchanging an appbox container, UCR is first dumped into a backup file and then restored. This second phase is buggy as it reads the backup base.conf and splits on ':' rather than ': '. Thus, the stored value gets an additional ' ' when restored, leading to ucr set 'domainname= nosamba.intranet' Ah okay. Why do you parse UCR by yourself? That's not good, even if you know to split at ': ' (which was obviously not done :D) there can also be issues with encodings. Can't you ucr.load(); json.dumps(dict(ucr)) for the backup? Fixed in univention-docker-container-mode 1.0.14-8.69.201701171421 (In reply to Florian Best from comment #4) > Ah okay. Why do you parse UCR by yourself? Using native UCR functions would be better, yes. But this fix is far less complicated when changing only the erroneous split(). OK - restore_data_before_setup in container OK - merged to 4.2-0 OK - YAML |