Bug 44346

Summary:	UCS 4.2 sources.list entry is missing if the upgrade fails
Product:	UCS	Reporter:	Stefan Gohmann <gohmann>
Component:	Update - Release updates	Assignee:	Philipp Hahn <hahn>
Status:	CLOSED FIXED	QA Contact:	Felix Botner <botner>
Severity:	normal
Priority:	P5	CC:	best, steuwer
Version:	UCS 4.2
Target Milestone:	UCS 4.2-0-errata
Hardware:	Other
OS:	Linux
See Also:	https://forge.univention.org/bugzilla/show_bug.cgi?id=44821
What kind of report is it?:	Bug Report	What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	3: Will affect average number of installed domains	How will those affected feel about the bug?:	5: Blocking further progress on the daily work
User Pain:	0.429	Enterprise Customer affected?:
School Customer affected?:		ISV affected?:
Waiting Support:		Flags outvoted (downgraded) after PO Review:
Ticket number:		Bug group (optional):
Max CVSS v3 score:
Bug Depends on:
Bug Blocks:	44037

Description Stefan Gohmann

2017-04-11 07:42:35 CEST

If the release update fails, the sources.list entry for UCS 4.2 is removed. 

Afterwards, the preup.sh check shows messages, that the package status is inconsistent. Thus, the admin should run 'dpkg --configure -a' or 'apt-get -f install' which will have bad consequences if the UCS 4.2 sources.list entry has been removed.

If the upgrade starts, we can save this info via UCR and can handle it in the next upgrade try and add the sources.list entry for this setup.

I've heard from two failed upgrades which run 'apt-get -f install' without the UCS 4.2 sources.list entry.

Comment 1 Philipp Hahn

2017-05-02 17:27:59 CEST

FYI: Bug #44290 triggers a failed update easily, when the time in the VM is not synchronized.

r79020 | Bug #44346 up: Pin tmporary sources list
r79019 | Bug #44346 up: Save temporary sources list
r79018 | Bug #44346 up: Remove unused temporary sources list functions
r79021 | Bug #44346 up: Pin tmporary sources list

Package: univention-updater
Version: 12.0.10-5A~4.2.0.201705021724
Branch: ucs_4.2-0

r79022 | Bug #44346 up: Pin tmporary sources list YAML
 univention-updater.yaml

Comment 4 Felix Botner

2017-05-11 15:45:48 CEST

grep "Pin temporary sources li" /var/univention/buildsystem2/mirror/testing/4.2/maintained/4.2-0/all/preup.sh

grep "Pin temporary sources li" /var/univention/buildsystem2/test_mirror/ftp/4.2/maintained/4.2-0/all/preup.sh

Please add the preup/postup change to the 4.2-0 testing preup/postup scripts.

Comment 5 Philipp Hahn

2017-05-11 15:54:11 CEST

curl http://apt.knut.univention.de/4.2/maintained/4.2-0/all/preup.sh
repo-ng-sign-release-file -i test_mirror/ftp/4.2/maintained/4.2-0/all/preup.sh -o test_mirror/ftp/4.2/maintained/4.2-0/all/preup.sh.gpg  -k 6B8BFD3C -p /etc/archive-keys/ucs4.0.txt

Comment 8 Felix Botner

2017-05-22 18:21:31 CEST

OK - postup/preup, 00_ucs_update_in_progress.list is created in preup and removed 
     in postup
OK - univention-updater
OK - YAML

REOPEN
 * who copies the preup/postup scripts to the official server?

Comment 9 Philipp Hahn

2017-05-23 09:00:27 CEST

I copied the filed fro mirror/testing/ to mirror/ftp/.
Will be published with the next "update_mirror.sh ftp/4.2/" call.

Comment 10 Felix Botner

2017-05-23 17:58:47 CEST

(In reply to Felix Botner from comment #8)
> OK - postup/preup, 00_ucs_update_in_progress.list is created in preup and
> removed 
>      in postup
> OK - univention-updater
> OK - YAML
> 
> REOPEN
>  * who copies the preup/postup scripts to the official server?

OK

Comment 11 Janek Walkenhorst

2017-05-24 10:48:00 CEST

<http://errata.software-univention.de/ucs/4.2/24.html>