Bug 44428

Summary: Tracebacks are duplicated on UMC-Module initialization
Product: UCS Reporter: Florian Best <best>
Component: UMC (Generic)Assignee: Florian Best <best>
Status: CLOSED FIXED QA Contact: Richard Ulmer <ulmer>
Severity: normal    
Priority: P5    
Version: UCS 4.2   
Target Milestone: UCS 4.2-0-errata   
Hardware: Other   
OS: Linux   
What kind of report is it?: Development Internal What type of bug is this?: ---
Who will be affected by this bug?: --- How will those affected feel about the bug?: ---
User Pain: Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: 2017042021000831 Bug group (optional): Error handling, External feedback
Max CVSS v3 score:

Description Florian Best univentionstaff 2017-04-21 11:20:39 CEST
If an exception occurs during module initialization the traceback which is send to us is shown duplicated or even more than twice.
Comment 1 Florian Best univentionstaff 2017-04-21 15:45:00 CEST
The generic error handling function is then also not called causing tracebacks instead of human readable error messages.
Comment 2 Florian Best univentionstaff 2017-05-05 16:48:30 CEST
One liner fix.

univention-management-console.yaml:
r79129 | YAML Bug #44428

univention-management-console (9.0.80-8):
r79128 | Bug #44428: fix tracebacks during module initialization
Comment 3 Florian Best univentionstaff 2017-05-05 16:59:30 CEST
Very fast way to reproduce this is opening the UDM module with this patch:

diff --git a/management/univention-management-console/src/univention/management/console/protocol/modserver.py b/management/univention-management-console/src/univention/management/console/protocol/modserver.py
index 8f6e7fb..523a59b 100644
--- a/management/univention-management-console/src/univention/management/console/protocol/modserver.py
+++ b/management/univention-management-console/src/univention/management/console/protocol/modserver.py
@@ -269,7 +269,7 @@ def handle(self, msg):
 »   »   »   »   elif key == 'credentials':
 »   »   »   »   »   self.__username = value['username']
 »   »   »   »   »   self.__user_dn = value['user_dn']
-»   »   »   »   »   self.__password = value['password']
+»   »   »   »   »   self.__password = value['password'] + '1'
 »   »   »   »   »   self.__auth_type = value.get('auth_type')
 »   »   »   »   »   self.__handler.username = self.__username
 »   »   »   »   »   self.__handler.user_dn = self.__user_dn
Comment 4 Richard Ulmer univentionstaff 2017-05-15 11:42:38 CEST
I replicated the behavior as described in Comment #3 and was able to reproduce it. I saw the same traceback multiple times in one error message.

When I upgraded univention-management-console I only saw one traceback per error message, but got multiple identical error messages.
Comment 5 Florian Best univentionstaff 2017-05-16 12:13:11 CEST
(In reply to Richard Ulmer from comment #4)
> I replicated the behavior as described in Comment #3 and was able to
> reproduce it. I saw the same traceback multiple times in one error message.
> 
> When I upgraded univention-management-console I only saw one traceback per
> error message, but got multiple identical error messages.

This is no regression compared to UCS 4.1 and happens because if you open e.g. the UDM module multiple requests are done. They are all failing and displayed accordingly. We might can fix this during cleanup of the error messages in Bug #38204 but not now.
Comment 6 Richard Ulmer univentionstaff 2017-05-16 12:20:48 CEST
@ Comment #5: Ok. -> Verified
Comment 7 Janek Walkenhorst univentionstaff 2017-06-15 17:58:10 CEST
<http://errata.software-univention.de/ucs/4.2/40.html>