Univention Bugzilla – Full Text Bug Listing |
Summary: | Samba: Want samba/min/protocol | ||
---|---|---|---|
Product: | UCS | Reporter: | Mathieu Simon <mathieu.simon> |
Component: | Samba4 | Assignee: | Florian Best <best> |
Status: | CLOSED DUPLICATE | QA Contact: | Arvid Requate <requate> |
Severity: | normal | ||
Priority: | P5 | CC: | best, damrose, requate |
Version: | UCS 4.2 | ||
Target Milestone: | --- | ||
Hardware: | Other | ||
OS: | Linux | ||
See Also: | https://forge.univention.org/bugzilla/show_bug.cgi?id=44591 | ||
What kind of report is it?: | --- | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: | |||
Attachments: |
Patch 1: Re-cleaned so it can be applied, adds minimal protocol version
Patch 2: Switch to samba/server/max/protocol so client minimal versions can be added |
Description
Mathieu Simon
2017-05-16 16:50:38 CEST
(In reply to Mathieu Simon from comment #0) > --- a/univention/templates/files/etc/samba/smb.conf.d/61univention-samba_misc > +++ b/univention/templates/files/etc/samba/smb.conf.d/61univention-samba_misc > @@ -26,6 +26,9 @@ if configRegistry.get('samba4/service/smb', 'smbd') in > ('smbd', 's3fs'): > > print '\tstore dos attributes = %s' % > configRegistry.get('samba/store_dos_attributes', 'yes') > > + if configRegistry.get('samba/min/protocol'): > + print '\tmax protocol = %s' % > configRegistry.get('samba/min/protocol') > + > if configRegistry.get('samba/max/protocol'): > print '\tmax protocol = %s' % > configRegistry.get('samba/max/protocol') The patch contains a typo → s/max protocol/min protocol/ *** This bug has been marked as a duplicate of bug 44591 *** Created attachment 8853 [details]
Patch 1: Re-cleaned so it can be applied, adds minimal protocol version
Created attachment 8854 [details]
Patch 2: Switch to samba/server/max/protocol so client minimal versions can be added
Even though the bug has been marked as duplicate, here is a second patch that
switches to the syntax of server max/min protocol since min protocol is a synonym anyway according to smb.conf manpage.
This allows adding a client minimum/maximum protocol version support if wanted.
Best regards
Mathieu
|