Univention Bugzilla – Full Text Bug Listing |
Summary: | Searching for the domain controller master in the system setup returns incorrect results | ||
---|---|---|---|
Product: | UCS | Reporter: | Tobias Birkefeld <birkefeld> |
Component: | System setup | Assignee: | Florian Best <best> |
Status: | CLOSED FIXED | QA Contact: | Felix Botner <botner> |
Severity: | normal | ||
Priority: | P5 | CC: | best, brodersen, damrose |
Version: | UCS 4.2 | ||
Target Milestone: | UCS 4.2-2-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
See Also: | http://forge.univention.org/bugzilla/show_bug.cgi?id=42918 | ||
What kind of report is it?: | Bug Report | What type of bug is this?: | 3: Simply Wrong: The implementation doesn't match the docu |
Who will be affected by this bug?: | 3: Will affect average number of installed domains | How will those affected feel about the bug?: | 3: A User would likely not purchase the product |
User Pain: | 0.154 | Enterprise Customer affected?: | Yes |
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | Bug group (optional): | ||
Max CVSS v3 score: | |||
Bug Depends on: | |||
Bug Blocks: | 45171 |
Description
Tobias Birkefeld
2017-08-08 18:45:02 CEST
Instead of the FQDN of the nameserver the FQDN of the _domaincontroller_master._tcp.$domainname SRV system is now used. univention-system-setup (10.0.10-43) 9eda8bd43f05 | Bug #45170: fix name of DC Master if the nameserver is not the DC Master itself univention-systen-setup.yaml 2fd1226363c3 | Bug #43745: Merge branch 'fbest/45253-42918-43683-45170-43745-45246-ad-member-mode-join' into 4.2-2 (In reply to Florian Best from comment #1) > Instead of the FQDN of the nameserver the FQDN of the > _domaincontroller_master._tcp.$domainname SRV system is now used. Would it be possible to check for the DNS record, and if that is not available, use the nameserver1 like it was before the change? I do not have a specific scenario at hand, but i can imagine the change could lead to regressions (In reply to Erik Damrose from comment #2) > (In reply to Florian Best from comment #1) > > Instead of the FQDN of the nameserver the FQDN of the > > _domaincontroller_master._tcp.$domainname SRV system is now used. > > Would it be possible to check for the DNS record, and if that is not > available, use the nameserver1 like it was before the change? I do not have > a specific scenario at hand, but i can imagine the change could lead to > regressions The diff of the changes is: -» » » fqdn = util.get_fqdn(nameserver) +» » » domain = util.get_ucs_domain(nameserver) +» » » if domain: +» » » » fqdn = util.resolve_domaincontroller_master_srv_record(nameserver, domain) +» » » else: +» » » » fqdn = util.get_fqdn(nameserver) » » » if fqdn: » » » » result['dc_name'] = fqdn I could only imagine to change on top of that: +» » » fqdn = None » » » domain = util.get_ucs_domain(nameserver) » » » if domain: » » » » fqdn = util.resolve_domaincontroller_master_srv_record(nameserver, domain) -» » » else: +» » » if not fqdn: » » » » fqdn = util.get_fqdn(nameserver) » » » if fqdn: » » » » result['dc_name'] = fqdn But I don't really think it's better / more correct. It would find a fqdn of a non UCS server. OK - external non master UCS master with domaincontroller record as DNS server => finds the UCS master OK - UCS master as DNS server => finds the master OK - Non UCS system without domaincontroller record as DNS server => network settings warning OK - code review OK - YAML |