Bug 45338

Summary:	Don't allow share names with consecutive whitespaces
Product:	UCS	Reporter:	Felix Botner <botner>
Component:	Samba4	Assignee:	Florian Best <best>
Status:	CLOSED FIXED	QA Contact:	Felix Botner <botner>
Severity:	normal
Priority:	P5	CC:	best, botner, gohmann, markus.daehlmann, meybohm, requate, scheinig
Version:	UCS 4.1
Target Milestone:	UCS 4.2-2-errata
Hardware:	Other
OS:	Linux
What kind of report is it?:	Bug Report	What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	1: Will affect a very few installed domains	How will those affected feel about the bug?:	5: Blocking further progress on the daily work
User Pain:	0.143	Enterprise Customer affected?:	Yes
School Customer affected?:	Yes	ISV affected?:
Waiting Support:		Flags outvoted (downgraded) after PO Review:
Ticket number:	2017021021000308, 2017033121000455, 2017090521000618	Bug group (optional):	External feedback, Troubleshooting
Max CVSS v3 score:
Bug Depends on:	38688
Bug Blocks:	38689

Description Felix Botner

2017-09-07 10:55:39 CEST

+++ This bug was initially created as a clone of Bug #38688 +++

Ticket#2015061121000295

Samba config parser reduces consecutive whitespaces to one.
If a share "a   b" is defined "/etc/samba/shares.conf.d/a\ \ \ b" is created and included in "/etc/samba/shares.conf" but samba tries to include "/etc/samba/shares.conf.d/a\ b".

testparm just gives a warning about that but samba-tool testparm dies with "ERROR: Unable to load default file" leading to bug38686

We should reduce consecutive whitespaces (maybe in general, for user and group names etc.?) and/or throw a syntax warning.

Comment 1 Felix Botner

2017-09-07 10:57:00 CEST

please merge univention-samba changes to univention-samba4

Comment 2 Felix Botner

2017-09-07 12:20:41 CEST

and create a bug for 4.1-4

Comment 3 Florian Best

2017-09-08 15:31:22 CEST

univention-samba4 (6.0.10-29):
a18852b52b68353d61ab017087d450f59240e516 | Merge branch 'fbest/45338-samba4-share-name-escaping' into 4.2-2
841d5fadda9ef6aeb8df92cc013740622b48f897 | Bug #45338: escape share names

univention-samba4.yaml:
3e90c29c35a0fcefb71d5e61f4c267ab167288f3 | Merge branch 'fbest/45338-samba4-share-name-escaping' into 4.2-2
2a62133546481fc5613b5fcfd8c3d1ba9e8022d9 | YAML Bug #45338

Comment 4 Felix Botner

2017-09-11 11:51:23 CEST

OK - YAML
OK - shares spaces
OK - update
OK - samba-tool drs showrepl

Comment 5 Arvid Requate

2017-09-13 16:35:10 CEST

<http://errata.software-univention.de/ucs/4.2/164.html>