Univention Bugzilla – Full Text Bug Listing |
Summary: | fix quoting in global acls | ||
---|---|---|---|
Product: | UCS | Reporter: | Daniel Tröder <troeder> |
Component: | Mail - Dovecot | Assignee: | Daniel Tröder <troeder> |
Status: | CLOSED FIXED | QA Contact: | Mail maintainers <mail-maintainers> |
Severity: | enhancement | ||
Priority: | P5 | CC: | best, scheinig, schwardt, stoeckigt, thorp-hansen |
Version: | UCS 4.2 | ||
Target Milestone: | UCS 4.2-3-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | Bug Report | What type of bug is this?: | 2: Improvement: Would be a product improvement |
Who will be affected by this bug?: | 3: Will affect average number of installed domains | How will those affected feel about the bug?: | 3: A User would likely not purchase the product |
User Pain: | 0.103 | Enterprise Customer affected?: | Yes |
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | 2016032321000374, 2017032421000405, 2017100621000202 | Bug group (optional): | |
Max CVSS v3 score: | |||
Bug Depends on: | 41138 | ||
Bug Blocks: | 45894, 45971 |
Description
Daniel Tröder
2017-12-21 10:58:30 CET
The identifiers in the ACLs in the global ACL file have to be quoted, if they contain spaces. commit 4108486d8a3082c382d4034f2303912c521981bc Bug #45921: fix quoting of identifier in global ACL file commit 5eac889a5452d9066c54f6dc19c83e46d4799e95 Bug #45921: changelog commit 12ab2302153da4b02a5b3334aad40e511d3a1b46 Bug #45921: advisory Package: univention-mail-dovecot Version: 3.0.1-5A~4.2.0.201712211105 Branch: ucs_4.2-0 Scope: errata4.2-3 The code change doesn't consider if there is a double quote (") in a value. (In reply to Florian Best from comment #2) > The code change doesn't consider if there is a double quote (") in a value. The first regex matches only if the <id> starts and ends with a double quote. <folder> and <acl> may not contain whitespace. Updated regular expression to prevent problems if the .* in <folder> matches too many characters: -glocal_acl_pattern1 = re.compile(r'(?P<folder>.+) "(?P<id>.+)" (?P<acl>\w+)') -glocal_acl_pattern2 = re.compile(r'(?P<folder>.+) (?P<id>.+) (?P<acl>\w+)') +glocal_acl_pattern1 = re.compile(r'(?P<folder>[^ ]+) "(?P<id>.+)" (?P<acl>\w+)') +glocal_acl_pattern2 = re.compile(r'(?P<folder>[^ ]+) (?P<id>.+) (?P<acl>\w+)') Tested with new and old/uncorrected ACLs. Both are correct after next folder modification. Package: univention-mail-dovecot Version: 3.0.1-6A~4.2.0.201712211551 Branch: ucs_4.2-0 Scope: errata4.2-3 → VERIFIED |