Univention Bugzilla – Full Text Bug Listing |
Summary: | Onetime reject adding a new user due to empty otherTelephone / otherMobile | ||
---|---|---|---|
Product: | UCS | Reporter: | Christina Scheinig <scheinig> |
Component: | AD Connector | Assignee: | Felix Botner <botner> |
Status: | CLOSED FIXED | QA Contact: | Arvid Requate <requate> |
Severity: | normal | ||
Priority: | P5 | CC: | botner, requate |
Version: | UCS 4.2 | ||
Target Milestone: | UCS 4.3-2-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
See Also: | https://forge.univention.org/bugzilla/show_bug.cgi?id=45252 | ||
What kind of report is it?: | Bug Report | What type of bug is this?: | 3: Simply Wrong: The implementation doesn't match the docu |
Who will be affected by this bug?: | 2: Will only affect a few installed domains | How will those affected feel about the bug?: | 2: A Pain – users won’t like this once they notice it |
User Pain: | 0.069 | Enterprise Customer affected?: | |
School Customer affected?: | Yes | ISV affected?: | |
Waiting Support: | Yes | Flags outvoted (downgraded) after PO Review: | |
Ticket number: | 2018061221000411 | Bug group (optional): | |
Max CVSS v3 score: |
Description
Christina Scheinig
2018-06-19 15:35:31 CEST
reproducible with -> udm users/user create --set username=user1 --set lastname=user1 --set password=univention --append mobileTelephoneNumber=111 If we add something in AD, we create the object with the "attributes" defined in the mapping and additionally modify the object according to the "post_attributes" mapping. So if the mapping has post_attributes (which is the case for user mapping) we execute a * add with the attributes * and a modify with the post_attributes all in the ADD block. The code for this "modify after add" also checks for a value and sets (ldap.MOD_DELETE, attr, None) in the modlist, but since nothing has been synced yet, this modlist is invalid. This happens only for post_attributes with a con_other_attribute, and i think only if the udm attribute is given only once (and therefor con_other_attribute is empty in the object) sync_from_ucs: modlist 3 [(2, u'displayName', [u'u4']), (1, 'otherMobile', None), (2, u'mobile', [u'111'])] NO_SUCH_ATTRIBUTE: {'info': '00002076: AtrErr: DSID-030F16E7, #1:\n\t0: 00002076: DSID-030F16E7, problem 1001 (NO_ATTRIBUTE_OR_VAL), data 0, Att 90287 (otherMobile)\n', 'desc': 'No such attribute'} I think we can safely remove this modlist.append((ldap.MOD_DELETE .... We added the object and ignored the post_attributes in the addlist, therefor the AD object has no such attributes and we do not have to worry about removing them. yaml: 928a76ec3f87bf9de4731510e5613169561d3d9e univention-ad-connector: 7ab21102bcb2b3fac0125329d1cb2c0c5a434fbc Code review: Ok, the corresponding code in S4-Connector looks the same. Test status in Jenkins: Ok Advisory: Ok |