Univention Bugzilla – Full Text Bug Listing |
Summary: | Improve UMC system diagnostic sysvol check | ||
---|---|---|---|
Product: | UCS | Reporter: | Arvid Requate <requate> |
Component: | UMC - System diagnostic | Assignee: | Julia Bremer <bremer> |
Status: | CLOSED FIXED | QA Contact: | Arvid Requate <requate> |
Severity: | enhancement | ||
Priority: | P5 | CC: | damrose |
Version: | UCS 4.3 | ||
Target Milestone: | UCS 4.3-2-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
What kind of report is it?: | Feature Request | What type of bug is this?: | --- |
Who will be affected by this bug?: | --- | How will those affected feel about the bug?: | --- |
User Pain: | Enterprise Customer affected?: | ||
School Customer affected?: | ISV affected?: | ||
Waiting Support: | Flags outvoted (downgraded) after PO Review: | ||
Ticket number: | 2018081621000464 | Bug group (optional): | |
Max CVSS v3 score: | |||
Bug Depends on: | 44876 | ||
Bug Blocks: | |||
Attachments: |
Patch for samba-tool
qa.patch |
Description
Arvid Requate
2018-08-13 16:43:58 CEST
Created attachment 9629 [details]
Patch for samba-tool
This patch improves samba-tool ntacl sysvolcheck to detect missing files and directories and issue a proper error message.
This is the first part of a solution to this bug.
Version: 4.0.1-4A~4.3.0.201810091102 Branch: ucs_4.3-0 Scope: errata4.3-2 5b8bbc5de2 Bug #47583: bump version 32fc581daf Bug #47583: Improved system diagnostik sysvol check error message Fixed this issue by filtering out the unhelpful samba error message. Created attachment 9737 [details] qa.patch Now all the output of sysvolcheck gets filtered out. I guess it's a typo, see attached diff. Also, we need to rebuild samba in errata4.3-2 with the patch of Comment 1. These patches need to be checked in into the subversion repository under a path that can be found out by running repo_get_version.py (e.g. dimma): ====================================================================== user@dimma:~$ repo_get_version.py -r 4.3 -s errata4.3-2 -p samba Package: samba Source rev tag : 125598 Current version: 2:4.7.8-1 Patch path: ~/svn/patches/samba/4.3-0-0-ucs/2:4.7.8-1-errata4.3-2/ Patch prefix: samba-4.7.8 ====================================================================== Finally we need an advisory entry for this bug in the following to files: * univention-management-console-module-diagnostic.yaml * samba.yaml I've added the entry to the first file now (commit 55c1edfc26). 2c2175e55e Bug #47583: Advisory 3f98dfc066 Bug #47583: Advisory 6250227955 Bug #47583: Merge branch 'jbremer/47583' into 4.3-2 19e26250227955 Bug #47583: Merge branch 'jbremer/47583' into 4.3-2 19e28b3a29 Bug #47583: Fixed typo Successful build Package: univention-management-console-module-diagnostic Version: 4.0.1-9A~4.3.0.201811191134 Branch: ucs_4.3-0 Scope: errata4.3-2 User: jbremer Successful build Package: samba Version: 2:4.7.8-1A~4.3.0.201811201204 Branch: ucs_4.3-0 Scope: errata4.3-2 User: jbremer I fixed the typo, edited the advisories and rebuild samba with the new patch. Ok, it works nicely. I just have one small nitpick about the error message. In my test-VM I get this: ========================================================================= WARNING: Check Samba sysvol ACLs for errors STDOUT: ERROR: File not found /var/lib/samba/sysvol/ar41i1.qa/Policies/{6AC1786C-016F-11D2-945F-00C04FB984F9} ERROR: File not found /var/lib/samba/sysvol/ar41i1.qa/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9} You can run `samba-tool ntacl sysvolreset` to fix the issue. ========================================================================= In this situation running "samba-tool ntacl sysvolreset" will not fix the error, so I would recommend to not show the "You can run" ... message. Maybe that's possible? In any case, I'd like to change the wording from "You can run .. to fix the issue" to "You may run ... to attempt to fix the issue" Successful build Package: univention-management-console-module-diagnostic Version: 4.0.1-10A~4.3.0.201811221414 Branch: ucs_4.3-0 Scope: errata4.3-2 User: jbremer ce14219f26 Bug #47583: Merge branch 'jbremer/bug47583' into 4.3-2 f00bad19a3 Bug #47583: Version bump 31ffd395be Bug #47583: Added translation for 42_samba_tool_ntacl_sysvolcheck f0b468d64c Bug #47583: Improved error message I adjusted the "fix"-message to "Running 'samba-tool ntacl sysvolreset' may fix the issue" In this particular error case, it will not show up any more. Verified: * Patch for samba-tool now outputs the path of missing directories * The UMC module presents the issue clearer * Advisories ok: samba.yaml univention-management-console-module-diagnostic.yaml |