Univention Bugzilla – Full Text Bug Listing |
Summary: | ERROR: incorrect DN SID component for member in object CN=Domain Users | ||
---|---|---|---|
Product: | UCS | Reporter: | Arvid Requate <requate> |
Component: | Samba4 | Assignee: | Felix Botner <botner> |
Status: | CLOSED FIXED | QA Contact: | Arvid Requate <requate> |
Severity: | normal | ||
Priority: | P5 | CC: | botner, damrose, grandjean, kenkel, requate, scheinig |
Version: | UCS 4.3 | ||
Target Milestone: | UCS 4.3-2-errata | ||
Hardware: | Other | ||
OS: | Linux | ||
URL: | https://bugzilla.samba.org/show_bug.cgi?id=13418 | ||
See Also: | https://forge.univention.org/bugzilla/show_bug.cgi?id=47842 | ||
What kind of report is it?: | Bug Report | What type of bug is this?: | 3: Simply Wrong: The implementation doesn't match the docu |
Who will be affected by this bug?: | 2: Will only affect a few installed domains | How will those affected feel about the bug?: | 3: A User would likely not purchase the product |
User Pain: | 0.103 | Enterprise Customer affected?: | |
School Customer affected?: | Yes | ISV affected?: | |
Waiting Support: | Yes | Flags outvoted (downgraded) after PO Review: | |
Ticket number: | 2018040621000285, 2018041821000388, 2018062021000389, 2018101221000314 | Bug group (optional): | |
Max CVSS v3 score: | |||
Bug Depends on: | 45982 | ||
Bug Blocks: | |||
Attachments: |
connector-s4.log for restore of uid=karsten.loho
orig 4.8 upstream patch with changes for 4.7 repl_meta_data.c qa.patch |
Description
Arvid Requate
2018-10-25 12:56:47 CEST
In the meantime it occurs again, that the customer removed and restored some students. There is a workaround but the script has to be executed after each remove and restore procedure manually. So the customer needs this issue to be fixed. I will set the waiting support flag. In an other school environment, this issue occurs again. This is not comfortable to fix this manually, especially in the event of unexpected occurrences. We edit the samba backend here, and mistakes can cause unforgivable consequences. FYI: This issue occurs in ucsschool environments and the problem itself appears with samba-tool dbcheck backported upstream patch, fixed the problem for me had to slightly modify the repl_meta_data.c patches (rewrite in 4.8) Created attachment 9725 [details]
orig 4.8 upstream patch with changes for 4.7 repl_meta_data.c
Created attachment 9727 [details]
qa.patch
I did a vimdiff of upstream vs you attached patch and found one line where it looks like two function arguments have been swapped.
uhh, yes the original patch is replmd_update_la_val(new_values, exact->v, dns[i].dsdb_dn, exact->dsdb_dn, - invocation_id, seq_num, - seq_num, now, false); + &ac->our_invocation_id, + ac->seq_num, ac->seq_num, + now, false); but replmd_update_la_va in 4.7 still has the version parameter static int replmd_update_la_val(TALLOC_CTX *mem_ctx, struct ldb_val *v, struct dsdb_dn *dsdb_dn, struct dsdb_dn *old_dsdb_dn, const struct GUID *invocation_id, uint64_t seq_num, uint64_t local_usn, NTTIME nttime, uint32_t version, bool deleted); as second last parameter, so this "0, now, false);" is wrong (and all the other replmd_update_la_val calls correctly use "now, 0, true);") fixed in 99_bug48054.quilt. Verified: * Patch fixed * Package rebuilt * UCS: functional tests after package update (DRS replication, dbcheck) * UCS: fixing dbcheck errors reproduced before update with scripts from Bug 45982 * UCS@school: same * Advisory: Ok, binary package version adjusted. |