Bug 48992

Summary: shellcheck: quoting bugs
Product: UCS Reporter: Arvid Requate <requate>
Component: GeneralAssignee: UCS maintainers <ucs-maintainers>
Status: NEW --- QA Contact: UCS maintainers <ucs-maintainers>
Severity: normal    
Priority: P5    
Version: UCS 4.4   
Target Milestone: ---   
Hardware: Other   
OS: Linux   
See Also: https://forge.univention.org/bugzilla/show_bug.cgi?id=48989
What kind of report is it?: Development Internal What type of bug is this?: ---
Who will be affected by this bug?: --- How will those affected feel about the bug?: ---
User Pain: Enterprise Customer affected?:
School Customer affected?: ISV affected?:
Waiting Support: Flags outvoted (downgraded) after PO Review:
Ticket number: Bug group (optional):
Max CVSS v3 score:
Attachments: SC2046_and_SC2086_quoting_issues.patch

Description Arvid Requate univentionstaff 2019-03-14 13:09:40 CET
Created attachment 9924 [details]
SC2046_and_SC2086_quoting_issues.patch

I used shellcheck on git/ucs to look for SC2046 and SC2086 quoting bugs:

find \( -name "*.inst" -o -name "*.sh" -o -name "*.postinst" \) -exec shellcheck {} \;

See attached patch for the most severe cases I found. I neglected missing quoting for things like "hostname.$domainname" etc.